[jira] [Reopened] (HADOOP-14216) Improve Configuration XML Parsing Performance

["Steve Loughran (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-14216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran reopened HADOOP-14216:
-------------------------------------

This is breaking XInclude for me, which I'm using to pull in resources (aws credentials) via an XInclude to a file:// URL in the resource /auth-keys.xml, which is itself pulled in from core-site.xml

Here's details on [my setup|https://steveloughran.blogspot.co.uk/2016/04/testing-against-s3-and-object-stores.html].

It's failing, even on the non IT tests, the ones which don't need a set of credentials to work. They still load in core-site, they still want to pull in XIncludes. They now fail.

I tried using the xi: prefix explicitly, but no, nothing there. 
{code}
  <xi:include xmlns:xi="http://www.w3.org/2001/XInclude"
    href="file:///home/stevel/.aws/html-keys.xml" >
  </xi:include>
{code}

(note: not the reai path, before anyone thinks of a way to steal my secrets)

What does work is remove the file:// prefix:
{code}
  <include xmlns="http://www.w3.org/2001/XInclude"
    href="///home/stevel/.aws/html-keys.xml" >
  </include>
{code}

Makes me thing the issue here is the fallback logic: if the XInclude href is a full URI, it should be used as is. Also, if the file is missing: log @ info before falling back, so people get a hint of what is playing up.

I now know enough about the problem to change my auth-keys file, so get tests running again. However, the XInclude reference logic has changed —I don't know who else is expecting file:// or other other references to work.

> Improve Configuration XML Parsing Performance
> ---------------------------------------------
>
>                 Key: HADOOP-14216
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14216
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>             Fix For: 2.9.0, 3.0.0-alpha3
>
>         Attachments: HADOOP-14216.1.patch, HADOOP-14216.2-branch-2.patch, HADOOP-14216.2.patch, HADOOP-14216.addendum.1.patch
>
>
> JIRA is to improve XML parsing performance through reuse and a change in XML parser (STAX)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org