Re: [I] InputFileSegmentNameGenerator raised NullPointerException when pattern contains optional group [pinot]

["wolfkill (via GitHub)" <gi...@apache.org>]

wolfkill commented on issue #13531:
URL: https://github.com/apache/pinot/issues/13531#issuecomment-4571181576

   This appears to be fixed by #13532 (`529fffbb888`). Current `InputFileSegmentNameGenerator` now converts a null optional regex group to an empty string before template replacement, and `InputFileSegmentNameGeneratorTest#testWithOptionalPattern` covers both matching and missing optional suffix cases.
   
   I also verified the focused test on current code:
   
   ```
   JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ./mvnw -pl pinot-segment-spi -am -Dtest=InputFileSegmentNameGeneratorTest#testWithOptionalPattern -Dsurefire.failIfNoSpecifiedTests=false test
   ```
   
   Result: 1 test run, 0 failures. This issue looks safe to close.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org