You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/12/19 16:34:08 UTC

Review Request 16386: CLOUDSTACK-5518: Fixing non contiguous vlan test case

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16386/
-----------------------------------------------------------

Review request for cloudstack and Girish Shilamkar.

Bugs: CLOUDSTACK-5518
https://issues.apache.org/jira/browse/CLOUDSTACK-5518

Repository: cloudstack-git

Description
-------

The issue in 5518 is, if newly added vlan range is getting used by other test cases, then that range will get considered as used and we are trying to remove the unused range.
The problem reported by Rayees is not the exact issue. I have updated the comments in the bug accordingly.

I have changed the code in test case to minimize the time interval between adding the new range and removing it so as to minimize the probability of it getting used by other test cases dynamically.

Also cleaned up the imports and improved other test case.

Diffs
-----

test/integration/component/test_non_contiguous_vlan.py 5ef1ec7

Diff: https://reviews.apache.org/r/16386/diff/

Testing
-------

Tested locally:

Log:
test_01_add_non_contiguous_ranges (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
test_02_add_existing_vlan_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
test_03_extend_contiguous_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
test_04_remove_unused_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
test_05_remove_used_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok

----------------------------------------------------------------------
Ran 5 tests in 304.525s

Thanks,

Gaurav Aradhye

Re: Review Request 16386: CLOUDSTACK-5518: Fixing non contiguous vlan test case

Posted by Girish Shilamkar <gi...@clogeny.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16386/#review30818
-----------------------------------------------------------

Ship it!


Committed to 4.3 and master

- Girish Shilamkar


On Dec. 19, 2013, 3:34 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16386/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 3:34 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5518
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5518
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The issue in 5518 is, if newly added vlan range is getting used by other test cases, then that range will get considered as used and we are trying to remove the unused range.
> The problem reported by Rayees is not the exact issue. I have updated the comments in the bug accordingly.
> 
> I have changed the code in test case to minimize the time interval between adding the new range and removing it so as to minimize the probability of it getting used by other test cases dynamically.
> 
> Also cleaned up the imports and improved other test case.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_non_contiguous_vlan.py 5ef1ec7 
> 
> Diff: https://reviews.apache.org/r/16386/diff/
> 
> 
> Testing
> -------
> 
> Tested locally:
> 
> Log:
> test_01_add_non_contiguous_ranges (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_02_add_existing_vlan_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_03_extend_contiguous_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_04_remove_unused_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_05_remove_used_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> 
> ----------------------------------------------------------------------
> Ran 5 tests in 304.525s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16386: CLOUDSTACK-5518: Fixing non contiguous vlan test case

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16386/#review30812
-----------------------------------------------------------


Commit 0faf772635cbc6ca26cdb52fbbe7d008db0e2277 in branch refs/heads/4.3 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0faf772 ]

CLOUDSTACK-5518: Fixing non contiguous vlan test case


- ASF Subversion and Git Services


On Dec. 19, 2013, 3:34 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16386/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 3:34 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5518
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5518
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The issue in 5518 is, if newly added vlan range is getting used by other test cases, then that range will get considered as used and we are trying to remove the unused range.
> The problem reported by Rayees is not the exact issue. I have updated the comments in the bug accordingly.
> 
> I have changed the code in test case to minimize the time interval between adding the new range and removing it so as to minimize the probability of it getting used by other test cases dynamically.
> 
> Also cleaned up the imports and improved other test case.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_non_contiguous_vlan.py 5ef1ec7 
> 
> Diff: https://reviews.apache.org/r/16386/diff/
> 
> 
> Testing
> -------
> 
> Tested locally:
> 
> Log:
> test_01_add_non_contiguous_ranges (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_02_add_existing_vlan_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_03_extend_contiguous_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_04_remove_unused_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_05_remove_used_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> 
> ----------------------------------------------------------------------
> Ran 5 tests in 304.525s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16386: CLOUDSTACK-5518: Fixing non contiguous vlan test case

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16386/#review30813
-----------------------------------------------------------


Commit 5d03fa83a23fa79599401ebd289d0e09a1f66d28 in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5d03fa8 ]

CLOUDSTACK-5518: Fixing non contiguous vlan test case


- ASF Subversion and Git Services


On Dec. 19, 2013, 3:34 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16386/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 3:34 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5518
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5518
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The issue in 5518 is, if newly added vlan range is getting used by other test cases, then that range will get considered as used and we are trying to remove the unused range.
> The problem reported by Rayees is not the exact issue. I have updated the comments in the bug accordingly.
> 
> I have changed the code in test case to minimize the time interval between adding the new range and removing it so as to minimize the probability of it getting used by other test cases dynamically.
> 
> Also cleaned up the imports and improved other test case.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_non_contiguous_vlan.py 5ef1ec7 
> 
> Diff: https://reviews.apache.org/r/16386/diff/
> 
> 
> Testing
> -------
> 
> Tested locally:
> 
> Log:
> test_01_add_non_contiguous_ranges (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_02_add_existing_vlan_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_03_extend_contiguous_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_04_remove_unused_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_05_remove_used_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> 
> ----------------------------------------------------------------------
> Ran 5 tests in 304.525s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 16386: CLOUDSTACK-5518: Fixing non contiguous vlan test case

Posted by Girish Shilamkar <gi...@clogeny.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16386/#review30817
-----------------------------------------------------------

Ship it!


Ship It!

- Girish Shilamkar


On Dec. 19, 2013, 3:34 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16386/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 3:34 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5518
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5518
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The issue in 5518 is, if newly added vlan range is getting used by other test cases, then that range will get considered as used and we are trying to remove the unused range.
> The problem reported by Rayees is not the exact issue. I have updated the comments in the bug accordingly.
> 
> I have changed the code in test case to minimize the time interval between adding the new range and removing it so as to minimize the probability of it getting used by other test cases dynamically.
> 
> Also cleaned up the imports and improved other test case.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_non_contiguous_vlan.py 5ef1ec7 
> 
> Diff: https://reviews.apache.org/r/16386/diff/
> 
> 
> Testing
> -------
> 
> Tested locally:
> 
> Log:
> test_01_add_non_contiguous_ranges (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_02_add_existing_vlan_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_03_extend_contiguous_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_04_remove_unused_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> test_05_remove_used_range (test_non_contiguous_vlan_fixed.TestNonContiguousVLANRanges) ... ok
> 
> ----------------------------------------------------------------------
> Ran 5 tests in 304.525s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>