You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "ocket8888 (via GitHub)" <gi...@apache.org> on 2023/02/08 15:15:33 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7345: TPv2 Query String Parameter filtering

ocket8888 opened a new pull request, #7345:
URL: https://github.com/apache/trafficcontrol/pull/7345

   This PR adds a feature to TPv2, specifically it ties table filters to URL-encoded parameters in the URL's query string. Now, for example, when you navigate to `/core/servers?domainName=test` the table will automatically apply a filter that shows only those servers with the `domainName` `test`. Multiple columns can be specified without restriction. Also, unlike in TPv1, the reverse binding is also upheld; when the user navigates to `/core/servers` and *then* filters to show only servers with a `domainName` of exactly `test`, the URL will update to reflect that i.e. `/core/servers?domainName=test`.
   
   This PR also fixes the `search` query string parameter being ever-present in the URL of table views by removing it whenever it would be blank.
   
   It also also fixes the search box adding to the users history, so that clicking a "back" button in the browser actually takes you to a different view instead of the same view with a different filter.
   
   Finally, many links were updated to make use of this by setting filters directly rather than relying on search matching.
   
   <hr/>
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Portal (experimental v2)
   
   ## What is the best way to verify this PR?
   Make sure the provided tests pass.
   
   ## PR submission checklist
   - [x] This PR has tests
   - [x] This PR doesn't need documentation
   - [x] This PR doesn't need a CHANGELOG.md entry
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] shamrickus merged pull request #7345: TPv2 Query String Parameter filtering

Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus merged PR #7345:
URL: https://github.com/apache/trafficcontrol/pull/7345


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org