You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Raffaele Borrelli (JIRA)" <ji...@apache.org> on 2011/04/27 21:20:03 UTC
[jira] [Created] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
-----------------------------------------------------------------------------
Key: PIVOT-737
URL: https://issues.apache.org/jira/browse/PIVOT-737
Project: Pivot
Issue Type: Bug
Components: wtk-terra
Affects Versions: 1.5.2
Reporter: Raffaele Borrelli
Fix For: 2.0.1
The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Sandro Martini <sa...@gmail.com>.
Hi all,
just comnmitted the fixed, and to ensure that all is good, add a
contextual menu on Right Click in both Tests User applications,
reusing the new version of ContextMenus (under Tests), with more
combinations of elements.
If something is not Ok, be free to reopen the ticket and/or tell me.
Bye,
Sandro
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Sandro Martini <sa...@gmail.com>.
Ok, my idea was to reuse this class from both test applications, but they are
inside the test subproject so I agree with you. I'll do the revert in next
days ...
Only a thing:
don't you think it would be useful to show the enabled/action simple usage
(as in the code I've committed) inside that Tutorial (maybe adding some info
on it in the related html page) ?
Don't worry, probably the answer to this is no ...
Bye
--
View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532p2908001.html
Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Greg Brown <gk...@verizon.net>.
Test code doesn't belong in the tutorial. I'd suggest copying your work to the tests project and revert the tutorial back to its original state.
G
On May 5, 2011, at 7:11 PM, Sandro Martini wrote:
> Just committed a simple addition to ContextMenus:
> add some items to the contextual menu, to see better what happens with
> items in different status (enabled, disabled, with action, and with
> action null). I'll reuse this class in tests for PIVOT-737 to verify
> if/how contextual menus will be handled with that fix.
>
> Sorry but now its too late, so I have to move the fix for PIVOT-737 in
> next days (but this week).
>
> Bye,
> Sandro
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Sandro Martini <sa...@gmail.com>.
Just committed a simple addition to ContextMenus:
add some items to the contextual menu, to see better what happens with
items in different status (enabled, disabled, with action, and with
action null). I'll reuse this class in tests for PIVOT-737 to verify
if/how contextual menus will be handled with that fix.
Sorry but now its too late, so I have to move the fix for PIVOT-737 in
next days (but this week).
Bye,
Sandro
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Sandro Martini <sa...@gmail.com>.
Hi,
> Since that update fixed Raffaele's problem, is there an immediate need to
> change the selection behavior?
For me there is no problem to fix this in the 2.0.2 (if we will do it) or
better in the 2.1 (and move this part in a dedicated jira ticket), but I'm
not sure that with my little fix the problem of Raffaele has been fully
solved ... I can try this evening to add a contextual menu in both test
applications (for Table and for List, if possible sharing the Contextual
menu code between them) and see in this case what happens, ok ?
So if it doesn't work I'd like to fix it during this week, but if it works,
move the selection on right click in another jira ticket for the 2.1 ... as
you I'd love to see the 2.0.1 release soon.
And in the meantime I can try to ask to Raffaele ...
Let's update.
Bye
--
View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532p2902491.html
Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Greg Brown <gk...@verizon.net>.
Oh, I see. You just changed the way editors are triggered:
http://mail-archives.apache.org/mod_mbox/pivot-commits/201105.mbox/%3c20110502221720.6712023888C2@eris.apache.org%3e
Since that update fixed Raffaele's problem, is there an immediate need to change the selection behavior?
On May 4, 2011, at 12:56 PM, Sandro Martini wrote:
> No, because I wasn't sure it was by design ... but as soon as possible (this
> week) I'll fix it.
>
> Bye
>
>
> --
> View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532p2899674.html
> Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Sandro Martini <sa...@gmail.com>.
No, because I wasn't sure it was by design ... but as soon as possible (this
week) I'll fix it.
Bye
--
View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532p2899674.html
Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Greg Brown <gk...@verizon.net>.
>> I'm actually inclined to say that right-click should never change selection
>> - only left-click (in other words, don't even make it an option).
> Ok, so I'll proceed to implement this (removing the selection with right
> click) ...
I thought you already checked that change in?
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Sandro Martini <sa...@gmail.com>.
>> Yes, I agree with you, but so there is only a corner case where that
>> exception is not thrown if I call the setEnabled(false) just before the
>> setAction() ... so if possible I'd like a runtime exception even in this
>> case.
>
>I don't think this is an exceptional condition. Calling setAction() should
automatically change the button's enabled state to match the action.
>
Ok, so if this is already Ok I'll revert my local changes (not committed)
and close this point (and maybe add a comment on this in the jira ticket).
>> So my proposal to add a style to enable/disable selections even on right
>> click (maybe with default enabled, like the current behavior, but for
>> anyone
>> not wanting it like in Raffaele case could be used to disable it), could
>> be
>> simpler and targeted to 2.0.1, while a more complex solution could go in
>> the
>> 2.1 (and in another jira ticket), ok ?
>
>I'm actually inclined to say that right-click should never change selection
- only left-click (in other words, don't even make it an option).
Ok, so I'll proceed to implement this (removing the selection with right
click) ... and we'll see in 2.1 if someone ask to us to re-implement this
feature (but working as in Ubuntu).
I hope to work on this tomorrow evening, and keep all updated (even with
comments in the jira ticket).
Note: to avoid side effects I'll add a simple contextual menu in test
classes used here, to verify that it will be opened on right click (I'm the
first to not trust my code :-) ).
Thank you again,
Sandro
--
View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532p2899626.html
Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Greg Brown <gk...@verizon.net>.
> So my proposal to add a style to enable/disable selections even on right
> click (maybe with default enabled, like the current behavior, but for anyone
> not wanting it like in Raffaele case could be used to disable it), could be
> simpler and targeted to 2.0.1, while a more complex solution could go in the
> 2.1 (and in another jira ticket), ok ?
I'm actually inclined to say that right-click should never change selection - only left-click (in other words, don't even make it an option).
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Greg Brown <gk...@verizon.net>.
> Yes, I agree with you, but so there is only a corner case where that
> exception is not thrown if I call the setEnabled(false) just before the
> setAction() ... so if possible I'd like a runtime exception even in this
> case.
I don't think this is an exceptional condition. Calling setAction() should automatically change the button's enabled state to match the action.
G
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Sandro Martini <sa...@gmail.com>.
Hi Greg,
>> Only a last thing, sorry, just to close the point:
>> even if I set the enables status of the Menu.Item to false, is it right
>> that
>> in the perform(Component source) , source is the Menu.Item, but as
>> inspected
>> by the debugger it has enabled = true ?
>
>Yes, because the code does not allow you to change the value to false (it
throws an exception).
Yes, I agree with you, but so there is only a corner case where that
exception is not thrown if I call the setEnabled(false) just before the
setAction() ... so if possible I'd like a runtime exception even in this
case.
>
>> If yes, I still have to ask to you only a last thing on this (long)
>> ticket
>> ... on what to do on selection with right click (as written in the jira
>> issue) ... comments ?
>
>You checked in a fix the other day to prevent selection unless the left
mouse button is clicked, correct?
Yes, or better, the editor (for tables, lists, tress) now will be opened
only at (double) Left click.
>This resolved Raffaele's issue, but it brings up an interesting question:
assuming that the user wants to >bring up a context menu in this case,
should a right click change the selection or leave it as-is?
Yes, this is the interesting part I'd like to discuss with all (and of
course with you :-) ), because in the current implementation I see a
Mac-like behavior.
Yesterday I've done some tests on Ubuntu 10.x and I see the same behavior as
Pivot:
right clicking on a row will select it (if it's selectable of course),
but in Ubuntu if there is a contextual menu it will be opened, while I don't
know in Pivot if we open the popup if present.
>
>On the Mac, right-clicking an item is a bit strange. If I have item "A"
selected and I right click on "B", "A" >remains selected, but "B" gets a
blue outline indicating that it is "sort of" selected. If I select an item
>from the context menu that appears, the selected action applies to "B", not
"A". This actually seems kind >of strange to me. As a user, I think I'd
expect the right click to bring up a menu only, not change the >selection.
But I'm curious to know what others think.
>
So my proposal to add a style to enable/disable selections even on right
click (maybe with default enabled, like the current behavior, but for anyone
not wanting it like in Raffaele case could be used to disable it), could be
simpler and targeted to 2.0.1, while a more complex solution could go in the
2.1 (and in another jira ticket), ok ?
Thanks for your today's comments, I'll wait for others tomorrow :-) .
Bye
--
View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532p2899531.html
Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Greg Brown <gk...@verizon.net>.
> Only a last thing, sorry, just to close the point:
> even if I set the enables status of the Menu.Item to false, is it right that
> in the perform(Component source) , source is the Menu.Item, but as inspected
> by the debugger it has enabled = true ?
Yes, because the code does not allow you to change the value to false (it throws an exception).
> If yes, I still have to ask to you only a last thing on this (long) ticket
> ... on what to do on selection with right click (as written in the jira
> issue) ... comments ?
You checked in a fix the other day to prevent selection unless the left mouse button is clicked, correct? This resolved Raffaele's issue, but it brings up an interesting question: assuming that the user wants to bring up a context menu in this case, should a right click change the selection or leave it as-is?
On the Mac, right-clicking an item is a bit strange. If I have item "A" selected and I right click on "B", "A" remains selected, but "B" gets a blue outline indicating that it is "sort of" selected. If I select an item from the context menu that appears, the selected action applies to "B", not "A". This actually seems kind of strange to me. As a user, I think I'd expect the right click to bring up a menu only, not change the selection. But I'm curious to know what others think.
G
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Sandro Martini <sa...@gmail.com>.
Ok, now I understand better :-) .
Only a last thing, sorry, just to close the point:
even if I set the enables status of the Menu.Item to false, is it right that
in the perform(Component source) , source is the Menu.Item, but as inspected
by the debugger it has enabled = true ?
If yes, I still have to ask to you only a last thing on this (long) ticket
... on what to do on selection with right click (as written in the jira
issue) ... comments ?
--
View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532p2899272.html
Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Greg Brown <gk...@verizon.net>.
The code is doing the right thing. If you assign an action to a button, you should use the action to manage the button's enabled state, not setEnabled().
On May 4, 2011, at 10:16 AM, Sandro Martini wrote:
> Hi Greg,
> if i add this
>
> whatIsThisMenuItem.setEnabled(false);
>
> after the line
>
> whatIsThisMenuItem.setAction(new Action() {
> ...
> });
>
> at runtime I get this exception:
>
> java.lang.IllegalArgumentException: Button and action enabled states are not
> consistent.
> at org.apache.pivot.wtk.Button.setEnabled(Button.java:401)
> at org.apache.pivot.wtk.Menu$Item.setEnabled(Menu.java:90)
> at
> org.apache.pivot.tutorials.menus.ContextMenus$1.configureContextMenu(ContextMenus.java:53)
> at
> org.apache.pivot.wtk.ApplicationContext$DisplayHost.processMouseEvent(ApplicationContext.java:858)
> at java.awt.Component.processEvent(Component.java:6054)
> at
> org.apache.pivot.wtk.ApplicationContext$DisplayHost.processEvent(ApplicationContext.java:709)
> at java.awt.Component.dispatchEventImpl(Component.java:4652)
> at java.awt.Component.dispatchEvent(Component.java:4482)
> at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577)
> at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4235)
> at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
> at java.awt.Container.dispatchEventImpl(Container.java:2085)
> at java.awt.Window.dispatchEventImpl(Window.java:2478)
> at java.awt.Component.dispatchEvent(Component.java:4482)
> at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:644)
> at java.awt.EventQueue.access$000(EventQueue.java:85)
> at java.awt.EventQueue$1.run(EventQueue.java:603)
> at java.awt.EventQueue$1.run(EventQueue.java:601)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
> at
> java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
> at java.awt.EventQueue$2.run(EventQueue.java:617)
> at java.awt.EventQueue$2.run(EventQueue.java:615)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
> at java.awt.EventQueue.dispatchEvent(EventQueue.java:614)
> at
> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
> at
> java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
> at
> java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
> at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
> at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
> at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
>
> note that in my case in my contextual menu now I have added other items (one
> before this item, and another after, just for example) , so I don't know it
> it's good to have this exception.
>
> But in any case I think that the issue is the following:
> if I add the same line but just before the setAction, i get no exception,
> and the related item is selectable and the action is executed ...
>
> I see that in the
> public void perform(Component source) {
> source is the Menu.Item, but as inspected by the debugger it has enabled =
> true (and that's strange) ... and probably should be fixed, and the caller
> of perform should call it only if source is enabled, ok ?
> Than as a workaround I suggest to check if source is enabled, otherwise do
> nothing (and maybe close the context menu).
>
> What do you think ?
>
> Bye,
> Sandro
>
>
> --
> View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532p2899010.html
> Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Sandro Martini <sa...@gmail.com>.
Hi Greg,
if i add this
whatIsThisMenuItem.setEnabled(false);
after the line
whatIsThisMenuItem.setAction(new Action() {
...
});
at runtime I get this exception:
java.lang.IllegalArgumentException: Button and action enabled states are not
consistent.
at org.apache.pivot.wtk.Button.setEnabled(Button.java:401)
at org.apache.pivot.wtk.Menu$Item.setEnabled(Menu.java:90)
at
org.apache.pivot.tutorials.menus.ContextMenus$1.configureContextMenu(ContextMenus.java:53)
at
org.apache.pivot.wtk.ApplicationContext$DisplayHost.processMouseEvent(ApplicationContext.java:858)
at java.awt.Component.processEvent(Component.java:6054)
at
org.apache.pivot.wtk.ApplicationContext$DisplayHost.processEvent(ApplicationContext.java:709)
at java.awt.Component.dispatchEventImpl(Component.java:4652)
at java.awt.Component.dispatchEvent(Component.java:4482)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4235)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
at java.awt.Container.dispatchEventImpl(Container.java:2085)
at java.awt.Window.dispatchEventImpl(Window.java:2478)
at java.awt.Component.dispatchEvent(Component.java:4482)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:644)
at java.awt.EventQueue.access$000(EventQueue.java:85)
at java.awt.EventQueue$1.run(EventQueue.java:603)
at java.awt.EventQueue$1.run(EventQueue.java:601)
at java.security.AccessController.doPrivileged(Native Method)
at
java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
at
java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
at java.awt.EventQueue$2.run(EventQueue.java:617)
at java.awt.EventQueue$2.run(EventQueue.java:615)
at java.security.AccessController.doPrivileged(Native Method)
at
java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:614)
at
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at
java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
note that in my case in my contextual menu now I have added other items (one
before this item, and another after, just for example) , so I don't know it
it's good to have this exception.
But in any case I think that the issue is the following:
if I add the same line but just before the setAction, i get no exception,
and the related item is selectable and the action is executed ...
I see that in the
public void perform(Component source) {
source is the Menu.Item, but as inspected by the debugger it has enabled =
true (and that's strange) ... and probably should be fixed, and the caller
of perform should call it only if source is enabled, ok ?
Than as a workaround I suggest to check if source is enabled, otherwise do
nothing (and maybe close the context menu).
What do you think ?
Bye,
Sandro
--
View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532p2899010.html
Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.
[jira] [Resolved] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini resolved PIVOT-737.
----------------------------------
Resolution: Fixed
Resolved.
Then to test multiple selection (for example to ensure no side effects), you can use the following test bxml files:
multiple_selection_list.bxml
multiple_selection_table.bxml
multiple_selection_tree.bxml
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027889#comment-13027889 ]
Sandro Martini commented on PIVOT-737:
--------------------------------------
Maybe now I understand the fix of Raffaele: prevent selection of elements using the mouse RIGHT button, but are we sure that this is the behavior that we want here now ?
At least on Windows, Right click usually opens a contextual menu (if any) or do nothing ... so this should become the new default for selections here.
Greg, Chris and of course Raffaele, what do you think ?
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Raffaele Borrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raffaele Borrelli updated PIVOT-737:
------------------------------------
The problem can be easily reproduced with any tableView with a TableViewRowEditor.
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035689#comment-13035689 ]
Greg Brown commented on PIVOT-737:
----------------------------------
It is preferable to leave things stable in SVN whenever possible. Reverting the change was the simplest way to do that.
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Raffaele Borrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raffaele Borrelli updated PIVOT-737:
------------------------------------
Affects Version/s: (was: 1.5.2)
2.0
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (PIVOT-737) TerraTableViewSkin opens
a TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035680#comment-13035680 ]
Sandro Martini edited comment on PIVOT-737 at 5/18/11 9:48 PM:
---------------------------------------------------------------
Just committed a new fix and some test bxml for multiple selection
was (Author: smartini):
I'm planning to redo the fix (for both things) now (if SVN is writable today).
You could have wait to revert the change.
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Raffaele Borrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raffaele Borrelli updated PIVOT-737:
------------------------------------
http://apache-pivot-users.399431.n3.nabble.com/Disable-Menu-Item-td2865710.html
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Brown reopened PIVOT-737:
------------------------------
The changes for this fix were reverted since they broke multi-select in ListView, TableView, and TreeView.
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Raffaele Borrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028019#comment-13028019 ]
Raffaele Borrelli commented on PIVOT-737:
-----------------------------------------
That is exactly what I wanted. I have a TableView with both a RowEditor and a contextual menu installed, right clicking should open the contextual menu, left clicking should start the row editor. Is this ok for you?
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028110#comment-13028110 ]
Sandro Martini commented on PIVOT-737:
--------------------------------------
Ciao Raffaele, Yes, even to me the proposed change (to mouseDown() ) makes sense, but I have to see what other Pivot developers think, because probably this part of the issue is by design (and after we have to test each Pivot component to see if it works in the same way) ... Greg, Chris, and others, comments ?
Note: I don't remember under Linux (for example GNome, in Ubuntu) if selections are handled even with the right mouse click, I'll verify as soon as possible and write here for reference.
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027882#comment-13027882 ]
Sandro Martini commented on PIVOT-737:
--------------------------------------
Just committed the fix for mouseClicked on TerraListViewSkin, TerraTableViewSkin , TerraTreeViewSkin and test the right behavior with TableViewTest2, ListViewTest2 .
I have to see better the same changes even for the mouseDown ...
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (PIVOT-737) TerraTableViewSkin opens
a TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027882#comment-13027882 ]
Sandro Martini edited comment on PIVOT-737 at 5/2/11 10:29 PM:
---------------------------------------------------------------
Just committed the fix for mouseClicked on TerraListViewSkin, TerraTableViewSkin , TerraTreeViewSkin and test the right behavior with TableViewTest2, ListViewTest2 .
was (Author: smartini):
Just committed the fix for mouseClicked on TerraListViewSkin, TerraTableViewSkin , TerraTreeViewSkin and test the right behavior with TableViewTest2, ListViewTest2 .
I have to see better the same changes even for the mouseDown ...
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (PIVOT-737) TerraTableViewSkin opens
a TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028110#comment-13028110 ]
Sandro Martini edited comment on PIVOT-737 at 5/3/11 10:25 PM:
---------------------------------------------------------------
Ciao Raffaele, Yes, even to me the proposed change (to mouseDown() ) makes sense, but this part of the issue is by design (and after we have to test each Pivot component to see if it works in the same way).
I've just tried what happens in Linux (for example in GNome, under Ubuntu 10.x):
selections inside table/list/trees are handled even with right click, and where there is a context menu (related to the selected element), it's opened.
At this point the only thing that I think we could do on right click on selections (to mouseDown() ) is to see if the current situation is working even for Raffaele (for example to work like in Ubuntu), or maybe think to add a style where we could eneble/disable selection on right click ... from an usability point of view this could be a little but useful feature I think.
Greg, Chris, and others, comments ?
was (Author: smartini):
Ciao Raffaele, Yes, even to me the proposed change (to mouseDown() ) makes sense, but I have to see what other Pivot developers think, because probably this part of the issue is by design (and after we have to test each Pivot component to see if it works in the same way) ... Greg, Chris, and others, comments ?
Note: I don't remember under Linux (for example GNome, in Ubuntu) if selections are handled even with the right mouse click, I'll verify as soon as possible and write here for reference.
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Raffaele Borrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036079#comment-13036079 ]
Raffaele Borrelli commented on PIVOT-737:
-----------------------------------------
Thanks Sandro and Greg, I was having the problem with multiple selection in my application but I couldn't figure out where it was coming from. Now everything works fine.
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027869#comment-13027869 ]
Sandro Martini commented on PIVOT-737:
--------------------------------------
Hi all,
on the contextual menu issue (in the original thread, on nabble), do you think could be useful for example to add a radio button in that demo (at the top of the window) so the user could choose between contextual menu enabled (default) and disabled, to see even if/when this is right ?
Or if it's not an issue maybe we could show there how to handle that situation. Or maybe this could become a sub-issue of this, if useful.
Tell me,
Bye,
Sandro
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by Greg Brown <gk...@verizon.net>.
I believe that issue was already resolved. The menu item was using an action, so the action itself has to be disabled. In other words, I believe it is working properly.
G
On May 3, 2011, at 6:41 PM, Sandro Martini (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028484#comment-13028484 ]
>
> Sandro Martini commented on PIVOT-737:
> --------------------------------------
>
> Hi Greg, I'll try to clarify the part related to the Contextual menu (I agree tha wasn't so clear, even for me, now that I re-read it :-) ):
> in the Nabble thread ( http://apache-pivot-users.399431.n3.nabble.com/Disable-Menu-Item-td2865710.html ) Raffaele said:
>> You can use the context-menu example provided by pivot tutorial. I just added the line of code: whatIsThisMenuItem.setEnabled(false);
> to the file ContextMenu.java (at line 40). The context menu is still visible and working. Can you reproduce it?
>>
>> In the meanwhile I found the problem. If the action is removed then setEnabled(false) warks as it should. Apparently you must have a null action, or the menu item is forced to be enabled. Is this true?
>>
> etc ...
>
> So this part of my proposal was that if I add the line
> whatIsThisMenuItem.setEnabled(false);
> in the ContextMenus Tutorial, the context menu is visible the same ... is it a bug ?
> And last, if Yes, what do you think if I'd add a radio button (on top of the window containing the components of that Tutorial) so we could see what happens enabling/disabling the contextual menu ? Otherwise I could add a similar Test class, more in line with user tests.
>
> I hope to be clear this time :-) ... what do you think ?
>
>
>> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
>> -----------------------------------------------------------------------------
>>
>> Key: PIVOT-737
>> URL: https://issues.apache.org/jira/browse/PIVOT-737
>> Project: Pivot
>> Issue Type: Bug
>> Components: wtk-terra
>> Affects Versions: 2.0
>> Reporter: Raffaele Borrelli
>> Assignee: Sandro Martini
>> Fix For: 2.0.1
>>
>>
>> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
>> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028484#comment-13028484 ]
Sandro Martini commented on PIVOT-737:
--------------------------------------
Hi Greg, I'll try to clarify the part related to the Contextual menu (I agree tha wasn't so clear, even for me, now that I re-read it :-) ):
in the Nabble thread ( http://apache-pivot-users.399431.n3.nabble.com/Disable-Menu-Item-td2865710.html ) Raffaele said:
> You can use the context-menu example provided by pivot tutorial. I just added the line of code: whatIsThisMenuItem.setEnabled(false);
to the file ContextMenu.java (at line 40). The context menu is still visible and working. Can you reproduce it?
>
> In the meanwhile I found the problem. If the action is removed then setEnabled(false) warks as it should. Apparently you must have a null action, or the menu item is forced to be enabled. Is this true?
>
etc ...
So this part of my proposal was that if I add the line
whatIsThisMenuItem.setEnabled(false);
in the ContextMenus Tutorial, the context menu is visible the same ... is it a bug ?
And last, if Yes, what do you think if I'd add a radio button (on top of the window containing the components of that Tutorial) so we could see what happens enabling/disabling the contextual menu ? Otherwise I could add a similar Test class, more in line with user tests.
I hope to be clear this time :-) ... what do you think ?
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini resolved PIVOT-737.
----------------------------------
Resolution: Fixed
Fixed, and to ensure that all is good, add a contextual menu on Right Click in both Tests User applications, reusing the new version of ContextMenus (under Tests), with more combinations of elements.
If something is not Ok, be free to reopen the ticket.
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028165#comment-13028165 ]
Greg Brown commented on PIVOT-737:
----------------------------------
Thanks for making this fix Sandro. I have not tested it, but your changes to the code look good.
I'm not sure what you mean by this:
"on the contextual menu issue (in the original thread, on nabble), do you think could be useful for example to add a radio button in that demo (at the top of the window) so the user could choose between contextual menu enabled (default) and disabled, to see even if/when this is right ?"
Can you clarify?
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035680#comment-13035680 ]
Sandro Martini commented on PIVOT-737:
--------------------------------------
I'm planning to redo the fix (for both things) now (if SVN is writable today).
You could have wait to revert the change.
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PIVOT-737) TerraTableViewSkin opens a
TableViewRowEditor listening to both mouse buttons
Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandro Martini reassigned PIVOT-737:
------------------------------------
Assignee: Sandro Martini
> TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
> -----------------------------------------------------------------------------
>
> Key: PIVOT-737
> URL: https://issues.apache.org/jira/browse/PIVOT-737
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0
> Reporter: Raffaele Borrelli
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
>
> The default TerraTableViewSkin initiates a TableViewRowEditor without regard for which mouse button is pressed.
> The problem is in the functions mouseClick() and mouseDown() which should be fixed to distinguish between left and right mouse click.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira