You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "e-mhui (via GitHub)" <gi...@apache.org> on 2025/01/11 13:30:53 UTC

[PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

e-mhui opened a new pull request, #8501:
URL: https://github.com/apache/seatunnel/pull/8501

   [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters
   
   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   -->
   
   ### Purpose of this pull request
   
   Fix #8500.
   
   ### Does this PR introduce _any_ user-facing change?
   
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
   If no, write 'No'.
   If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
   -->
   
   No.
   
   ### How was this patch tested?
   
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
   -->
   
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   * [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#discussion_r1919491142


##########
seatunnel-connectors-v2/connector-file/connector-file-sftp/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sftp/system/SFTPFileSystem.java:
##########
@@ -154,6 +155,29 @@ private boolean exists(ChannelSftp channel, Path file) throws IOException {
         }
     }
 
+    private String quote(String path) {
+        byte[] _path = path.getBytes(StandardCharsets.UTF_8);
+        int count = 0;
+        for (int i = 0; i < _path.length; i++) {
+            byte b = _path[i];
+            if (b == '\\' || b == '?' || b == '*') {
+                count++;
+            }
+        }
+        if (count == 0) {
+            return path;
+        }
+        byte[] _path2 = new byte[_path.length + count];
+        for (int i = 0, j = 0; i < _path.length; i++) {
+            byte b = _path[i];
+            if (b == '\\' || b == '?' || b == '*') {
+                _path2[j++] = '\\';
+            }
+            _path2[j++] = b;
+        }
+        return new String(_path2, 0, _path2.length, StandardCharsets.UTF_8);
+    }

Review Comment:
   put it in https://github.com/apache/seatunnel/tree/dev/seatunnel-connectors-v2/connector-file/connector-file-sftp/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/sftp



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#issuecomment-2592469300

   > Hi @e-mhui , does other file system will face same problems?
   
   @Hisoka-X Other file systems will not have this problem. This is because the code in jsch uses `get` to retrieve the file stream, which calls the "isUnique" method to determine if the file is unique. However, file names with wildcards will match multiple files, causing a uniqueness error. If we already know the file exists, we can add escape characters to avoid this problem.
   
   https://github.com/rtyley/jsch/blob/96b0558b66ec8982e708e46b6e5a254a3650d01b/src/com/jcraft/jsch/ChannelSftp.java#L864
   
   ```java
   public InputStream get(String src, final SftpProgressMonitor monitor, final long skip) throws SftpException{
   
       try{
         ((MyPipedInputStream)io_in).updateReadSide();
   
         src=remoteAbsolutePath(src);
         src=isUnique(src);
        //........
      }
   
     /**
      * This method will check if the given string can be expanded to the
      * unique string.  If it can be expanded to mutiple files, SftpException
      * will be thrown.
      * @return the returned string is unquoted.
      */
     private String isUnique(String path) throws SftpException, Exception{
       Vector v=glob_remote(path);
       if(v.size()!=1){
         throw new SftpException(SSH_FX_FAILURE, path+" is not unique: "+v.toString());
       }
       return (String)(v.elementAt(0));
     }
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#issuecomment-2585284874

   > @e-mhui Thank you for your contribution. Please open ci according to the guidance and add the tests corresponding to the modified parts.
   
   Ok, I'll add the test later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "corgy-w (via GitHub)" <gi...@apache.org>.
corgy-w commented on code in PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#discussion_r1912429874


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-sftp-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/fstp/SftpFileIT.java:
##########
@@ -113,6 +113,15 @@ public void startUp() throws Exception {
                 "/home/seatunnel/tmp/seatunnel/read/xml/name=tyrantlucifer/hobby=coding/e2e.xml",
                 sftpContainer);
 
+        ContainerUtil.copyFileIntoContainers(
+                "/wildcard/e*e.txt",
+                "/home/seatunnel/tmp/seatunnel/read/wildcard/e*e.txt",

Review Comment:
   See ci, there is a problem with this file path



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 merged PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on code in PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#discussion_r1921034906


##########
seatunnel-connectors-v2/connector-file/connector-file-sftp/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sftp/system/SFTPFileSystem.java:
##########
@@ -154,6 +155,29 @@ private boolean exists(ChannelSftp channel, Path file) throws IOException {
         }
     }
 
+    private String quote(String path) {
+        byte[] _path = path.getBytes(StandardCharsets.UTF_8);
+        int count = 0;
+        for (int i = 0; i < _path.length; i++) {
+            byte b = _path[i];
+            if (b == '\\' || b == '?' || b == '*') {
+                count++;
+            }
+        }
+        if (count == 0) {
+            return path;
+        }
+        byte[] _path2 = new byte[_path.length + count];
+        for (int i = 0, j = 0; i < _path.length; i++) {
+            byte b = _path[i];
+            if (b == '\\' || b == '?' || b == '*') {
+                _path2[j++] = '\\';
+            }
+            _path2[j++] = b;
+        }
+        return new String(_path2, 0, _path2.length, StandardCharsets.UTF_8);
+    }

Review Comment:
   Thx, please review again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "corgy-w (via GitHub)" <gi...@apache.org>.
corgy-w commented on PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#issuecomment-2585284406

   @e-mhui Thank you for your contribution. Please open ci according to the guidance and add the tests corresponding to the modified parts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on code in PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#discussion_r1912430872


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-sftp-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/fstp/SftpFileIT.java:
##########
@@ -113,6 +113,15 @@ public void startUp() throws Exception {
                 "/home/seatunnel/tmp/seatunnel/read/xml/name=tyrantlucifer/hobby=coding/e2e.xml",
                 sftpContainer);
 
+        ContainerUtil.copyFileIntoContainers(
+                "/wildcard/e*e.txt",
+                "/home/seatunnel/tmp/seatunnel/read/wildcard/e*e.txt",

Review Comment:
   It seems that Windows does not support file names with wildcard characters. Can test cases bypass Windows?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on code in PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#discussion_r1912659932


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-sftp-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/fstp/SftpFileIT.java:
##########
@@ -113,6 +115,17 @@ public void startUp() throws Exception {
                 "/home/seatunnel/tmp/seatunnel/read/xml/name=tyrantlucifer/hobby=coding/e2e.xml",
                 sftpContainer);
 
+        // Windows does not support files with wildcard characters. We can rename `e2e.txt` to
+        // `e*e.txt` when copying to a container
+        ContainerUtil.copyFileIntoContainers(
+                "/wildcard/e2e.txt",
+                "/home/seatunnel/tmp/seatunnel/read/wildcard/e*e.txt",
+                sftpContainer);
+
+        ContainerUtil.copyFileIntoContainers(
+                "/wildcard/e2e.txt",

Review Comment:
   Thx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#discussion_r1917557617


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-sftp-e2e/src/test/resources/text/sftp_file_text_wildcard_character_to_assert.conf:
##########
@@ -0,0 +1,117 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+env {
+  parallelism = 1
+  job.mode = "BATCH"
+
+  # You can set spark configuration here
+  spark.app.name = "SeaTunnel"
+  spark.executor.instances = 1
+  spark.executor.cores = 1
+  spark.executor.memory = "1g"
+  spark.master = local
+}
+
+source {
+  SftpFile {
+    host = "sftp"
+    port = 22
+    user = seatunnel
+    password = pass
+    path = "tmp/seatunnel/read/wildcard/"
+    file_format_type = "text"
+    plugin_output = "sftp"
+    schema = {
+      fields {
+        c_map = "map<string, string>"
+        c_array = "array<int>"
+        c_string = string
+        c_boolean = boolean
+        c_tinyint = tinyint
+        c_smallint = smallint
+        c_int = int
+        c_bigint = bigint
+        c_float = float
+        c_double = double
+        c_bytes = bytes
+        c_date = date
+        c_decimal = "decimal(38, 18)"
+        c_timestamp = timestamp
+        c_row = {
+          c_map = "map<string, string>"
+          c_array = "array<int>"
+          c_string = string
+          c_boolean = boolean
+          c_tinyint = tinyint
+          c_smallint = smallint
+          c_int = int
+          c_bigint = bigint
+          c_float = float
+          c_double = double
+          c_bytes = bytes
+          c_date = date
+          c_decimal = "decimal(38, 18)"
+          c_timestamp = timestamp
+        }
+      }
+    }
+  }
+}
+
+sink {
+  Assert {
+    plugin_input = "sftp"
+    rules {
+      row_rules = [
+        {
+          rule_type = MAX_ROW

Review Comment:
   ```suggestion
             rule_type = MIN_ROW
   ```



##########
seatunnel-connectors-v2/connector-file/connector-file-sftp/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sftp/system/SFTPFileSystem.java:
##########
@@ -154,6 +155,29 @@ private boolean exists(ChannelSftp channel, Path file) throws IOException {
         }
     }
 
+    private String quote(String path) {
+        byte[] _path = path.getBytes(StandardCharsets.UTF_8);
+        int count = 0;
+        for (int i = 0; i < _path.length; i++) {
+            byte b = _path[i];
+            if (b == '\\' || b == '?' || b == '*') {
+                count++;
+            }
+        }
+        if (count == 0) {
+            return path;
+        }
+        byte[] _path2 = new byte[_path.length + count];
+        for (int i = 0, j = 0; i < _path.length; i++) {
+            byte b = _path[i];
+            if (b == '\\' || b == '?' || b == '*') {
+                _path2[j++] = '\\';
+            }
+            _path2[j++] = b;
+        }
+        return new String(_path2, 0, _path2.length, StandardCharsets.UTF_8);
+    }

Review Comment:
   Please add a UT for this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on code in PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#discussion_r1919373540


##########
seatunnel-connectors-v2/connector-file/connector-file-sftp/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sftp/system/SFTPFileSystem.java:
##########
@@ -154,6 +155,29 @@ private boolean exists(ChannelSftp channel, Path file) throws IOException {
         }
     }
 
+    private String quote(String path) {
+        byte[] _path = path.getBytes(StandardCharsets.UTF_8);
+        int count = 0;
+        for (int i = 0; i < _path.length; i++) {
+            byte b = _path[i];
+            if (b == '\\' || b == '?' || b == '*') {
+                count++;
+            }
+        }
+        if (count == 0) {
+            return path;
+        }
+        byte[] _path2 = new byte[_path.length + count];
+        for (int i = 0, j = 0; i < _path.length; i++) {
+            byte b = _path[i];
+            if (b == '\\' || b == '?' || b == '*') {
+                _path2[j++] = '\\';
+            }
+            _path2[j++] = b;
+        }
+        return new String(_path2, 0, _path2.length, StandardCharsets.UTF_8);
+    }

Review Comment:
   Hello, this is my first pr. Where should I add the test case for the individual method,thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "corgy-w (via GitHub)" <gi...@apache.org>.
corgy-w commented on code in PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#discussion_r1912431490


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-sftp-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/fstp/SftpFileIT.java:
##########
@@ -113,6 +113,15 @@ public void startUp() throws Exception {
                 "/home/seatunnel/tmp/seatunnel/read/xml/name=tyrantlucifer/hobby=coding/e2e.xml",
                 sftpContainer);
 
+        ContainerUtil.copyFileIntoContainers(
+                "/wildcard/e*e.txt",
+                "/home/seatunnel/tmp/seatunnel/read/wildcard/e*e.txt",

Review Comment:
   Try to isolate this test by trying '@DisabledOnOs(OS.WINDOWS)'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "corgy-w (via GitHub)" <gi...@apache.org>.
corgy-w commented on code in PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#discussion_r1912602910


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-sftp-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/fstp/SftpFileIT.java:
##########
@@ -113,6 +115,17 @@ public void startUp() throws Exception {
                 "/home/seatunnel/tmp/seatunnel/read/xml/name=tyrantlucifer/hobby=coding/e2e.xml",
                 sftpContainer);
 
+        // Windows does not support files with wildcard characters. We can rename `e2e.txt` to
+        // `e*e.txt` when copying to a container
+        ContainerUtil.copyFileIntoContainers(
+                "/wildcard/e2e.txt",
+                "/home/seatunnel/tmp/seatunnel/read/wildcard/e*e.txt",
+                sftpContainer);
+
+        ContainerUtil.copyFileIntoContainers(
+                "/wildcard/e2e.txt",

Review Comment:
   File forgot to submit when pushing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Hotfix][Connector-V2][SFTP] Add quote to sftp file names with wildcard characters [seatunnel]

Posted by "e-mhui (via GitHub)" <gi...@apache.org>.
e-mhui commented on code in PR #8501:
URL: https://github.com/apache/seatunnel/pull/8501#discussion_r1912435796


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-sftp-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/fstp/SftpFileIT.java:
##########
@@ -113,6 +113,15 @@ public void startUp() throws Exception {
                 "/home/seatunnel/tmp/seatunnel/read/xml/name=tyrantlucifer/hobby=coding/e2e.xml",
                 sftpContainer);
 
+        ContainerUtil.copyFileIntoContainers(
+                "/wildcard/e*e.txt",
+                "/home/seatunnel/tmp/seatunnel/read/wildcard/e*e.txt",

Review Comment:
   Thx, I'll try again



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org