You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/01 11:35:37 UTC
[GitHub] [flink] florianakos commented on a change in pull request #13995: [FLINK-20055] [runtime/config] - hide sensitive datadog API key from logs
florianakos commented on a change in pull request #13995:
URL: https://github.com/apache/flink/pull/13995#discussion_r533341428
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java
##########
@@ -44,7 +44,8 @@
public static final String FLINK_CONF_FILENAME = "flink-conf.yaml";
// the keys whose values should be hidden
- private static final String[] SENSITIVE_KEYS = new String[] {"password", "secret", "fs.azure.account.key"};
+ private static final String[] SENSITIVE_KEYS = new String[] {"password", "secret",
+ "fs.azure.account.key", "metrics.reporter.dghttp.apikey"};
Review comment:
My idea was to follow the previous example when the Azure key was added and for that the full key was used.
But I agree with your opinion so I will fix it shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org