You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/12/22 13:34:13 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3388: ARTEMIS-3041 Allow encrypted data source property values
brusdev opened a new pull request #3388:
URL: https://github.com/apache/activemq-artemis/pull/3388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3388: ARTEMIS-3041 Allow encrypted data source property values
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3388:
URL: https://github.com/apache/activemq-artemis/pull/3388#issuecomment-749622369
@brusdev / @fvaleri I will merge this now.. feel free to follow up with another PR for doc changes if you guys decide to improve docs on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3388: ARTEMIS-3041 Allow encrypted data source property values
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3388:
URL: https://github.com/apache/activemq-artemis/pull/3388#issuecomment-749548770
Many data source properties contain sensitive values, like the username and the value encryption for the data source properties is optional so I would not limit what properties the user can encrypt.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] fvaleri commented on pull request #3388: ARTEMIS-3041 Allow encrypted data source property values
Posted by GitBox <gi...@apache.org>.
fvaleri commented on pull request #3388:
URL: https://github.com/apache/activemq-artemis/pull/3388#issuecomment-749544857
It would probably make sense to do this only for the password key, as the documentation says: "Apache ActiveMQ Artemis can be configured to use 'masked' passwords in its configuration files."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3388: ARTEMIS-3041 Allow encrypted data source property values
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3388:
URL: https://github.com/apache/activemq-artemis/pull/3388#issuecomment-750841091
@fvaleri I have just created the #3391 to improve the doc about JDBC connection pooling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] fvaleri commented on pull request #3388: ARTEMIS-3041 Allow encrypted data source property values
Posted by GitBox <gi...@apache.org>.
fvaleri commented on pull request #3388:
URL: https://github.com/apache/activemq-artemis/pull/3388#issuecomment-749549501
> Many data source properties contain sensitive values, like the username and the value encryption for the data source properties is optional so I would not limit what properties the user can encrypt.
Agree, but then we should also update the doc, adding a note about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] fvaleri commented on pull request #3388: ARTEMIS-3041 Allow encrypted data source property values
Posted by GitBox <gi...@apache.org>.
fvaleri commented on pull request #3388:
URL: https://github.com/apache/activemq-artemis/pull/3388#issuecomment-750850941
Thanks @brusdev , that's great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3388: ARTEMIS-3041 Allow encrypted data source property values
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3388:
URL: https://github.com/apache/activemq-artemis/pull/3388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org