[GitHub] [iceberg] kbendick commented on a change in pull request #3857: Flink 1.13: Add SerializableTable test cases.

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #3857:
URL: https://github.com/apache/iceberg/pull/3857#discussion_r780826016



##########
File path: flink/v1.13/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java
##########
@@ -67,6 +71,16 @@
   private TestHelpers() {
   }
 
+  public static <T> T roundTripKryoSerialize(Class<T> clazz, T table) throws IOException {

Review comment:
       I agree it would be useful for other tests. We have similar test helper in Spark for roundTripKryoSerializer.
   
   Question / nit: Does the name of the second argument of type `T` have to be `table`? This feels like it could be used with a lot more than just table objects. Maybe we should just change the name to something more generic like `item` or `toTest`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org