You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/14 17:11:38 UTC

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

wcarlson5 commented on a change in pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#discussion_r632673138



##########
File path: streams/src/test/java/org/apache/kafka/streams/kstream/SuppressedTest.java
##########
@@ -46,13 +48,13 @@ public void bufferBuilderShouldBeConsistent() {
         assertThat(
             "keys alone should be set",
             maxRecords(2L),
-            is(new EagerBufferConfigImpl(2L, MAX_VALUE))
+            is(new EagerBufferConfigImpl(2L, MAX_VALUE, Collections.emptyMap()))

Review comment:
       @vichu Can you add some tests that don't just use an empty map?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org