[jira] [Resolved] (IMPALA-5923) We're printing a binary ID in ChildQuery::Cancel()

["Lars Volker (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Volker resolved IMPALA-5923.
---------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.11.0


IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()

ChildQuery::Cancel() prints a binary ID into the log which can show up
as random characters. One fix is to print it as a hex string.

I tested this by running test_cancellation::test_cancel_insert and
making sure the ID is printed as hex.

This change also removes PrintAsHex() which was broken and unused.

Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Reviewed-on: http://gerrit.cloudera.org:8080/8050
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins

> We're printing a binary ID in ChildQuery::Cancel()
> --------------------------------------------------
>
>                 Key: IMPALA-5923
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5923
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.11.0
>            Reporter: Lars Volker
>            Assignee: Lars Volker
>            Priority: Critical
>              Labels: newbie, ramp-up
>             Fix For: Impala 2.11.0
>
>
> We should not print a binary ID in {{ChildQuery::Cancel()}}.
> {noformat}
> I0912 10:07:00.892400  1184 child-query.cc:131] Cancelling and closing child query with operation id: kգz^7M<F7>^@^@^@^@<D9>^]l<B7>
> {noformat}
> {code}
> 123 void ChildQuery::Cancel() {
> 124   // Do not hold lock_ while calling into parent_server_ to avoid deadlock.
> 125   {
> 126     lock_guard<mutex> l(lock_);
> 127     is_cancelled_ = true;
> 128     if (!is_running_) return;
> 129     is_running_ = false;
> 130   }
> 131   VLOG_QUERY << "Cancelling and closing child query with operation id: "
> 132              << hs2_handle_.operationId.guid;
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)