You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jayush Luniya <jl...@hortonworks.com> on 2017/11/01 17:14:12 UTC
Re: Review Request 63441: Remove Slider from Ambari stack definition
of HDP 3.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63441/#review189818
-----------------------------------------------------------
This will break HIVE LLAP as it uses slider. Please don't make any changes to HDP-3.0 stack for now.
- Jayush Luniya
On Oct. 31, 2017, 1:35 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63441/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 1:35 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-22340
> https://issues.apache.org/jira/browse/AMBARI-22340
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Slider is no longer a service on it's own in HDP 3.0, it is a part of YARN. So it should be removed from the stack definition.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml db490c9
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-client.xml adeba58
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-env.xml ce06a18
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-log4j.xml cd9b2a4
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/kerberos.json 8f07b42
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/metainfo.xml 168a2df
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/files/hbaseSmokeVerify.sh 5c320c0
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/__init__.py 5561e10
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params.py c03329c
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_linux.py 350be45
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_windows.py fd2f358
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/service_check.py 8582b5e
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider.py 83c5629
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider_client.py 45c7785
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/templates/storm-slider-env.sh.j2 8022a4b
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/service_advisor.py 5614868
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 061587d
> ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 23f558d
>
>
> Diff: https://reviews.apache.org/r/63441/diff/1/
>
>
> Testing
> -------
>
> Tested on local vagrant cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 63441: Remove Slider from Ambari stack definition
of HDP 3.0
Posted by Miklos Gergely <mg...@hortonworks.com>.
> On Nov. 1, 2017, 5:14 p.m., Jayush Luniya wrote:
> > This will break HIVE LLAP as it uses slider. Please don't make any changes to HDP-3.0 stack for now.
>
> Miklos Gergely wrote:
> Currently there is no Slider package in the HDP-3.0 yum repos, so even if this dependency is still there it is impossible to install Hive with Ambari, as Slider can not be installed for HDP-3.0, the Ambari install will fail at the point when it looks for the Slider packages.
I've also discussed the situation with a Slider developer (Gour Saha) and he confirmed that Slider will not be present in HDP-3.0 as a separate service. I don't see why to keep it in the stack definition.
- Miklos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63441/#review189818
-----------------------------------------------------------
On Oct. 31, 2017, 1:35 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63441/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 1:35 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-22340
> https://issues.apache.org/jira/browse/AMBARI-22340
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Slider is no longer a service on it's own in HDP 3.0, it is a part of YARN. So it should be removed from the stack definition.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml db490c9
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-client.xml adeba58
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-env.xml ce06a18
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-log4j.xml cd9b2a4
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/kerberos.json 8f07b42
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/metainfo.xml 168a2df
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/files/hbaseSmokeVerify.sh 5c320c0
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/__init__.py 5561e10
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params.py c03329c
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_linux.py 350be45
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_windows.py fd2f358
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/service_check.py 8582b5e
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider.py 83c5629
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider_client.py 45c7785
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/templates/storm-slider-env.sh.j2 8022a4b
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/service_advisor.py 5614868
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 061587d
> ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 23f558d
>
>
> Diff: https://reviews.apache.org/r/63441/diff/1/
>
>
> Testing
> -------
>
> Tested on local vagrant cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 63441: Remove Slider from Ambari stack definition
of HDP 3.0
Posted by Miklos Gergely <mg...@hortonworks.com>.
> On Nov. 1, 2017, 5:14 p.m., Jayush Luniya wrote:
> > This will break HIVE LLAP as it uses slider. Please don't make any changes to HDP-3.0 stack for now.
>
> Miklos Gergely wrote:
> Currently there is no Slider package in the HDP-3.0 yum repos, so even if this dependency is still there it is impossible to install Hive with Ambari, as Slider can not be installed for HDP-3.0, the Ambari install will fail at the point when it looks for the Slider packages.
>
> Miklos Gergely wrote:
> I've also discussed the situation with a Slider developer (Gour Saha) and he confirmed that Slider will not be present in HDP-3.0 as a separate service. I don't see why to keep it in the stack definition.
Just one more thing: In this patch I was only removing Slider 0.91.0.3.0 from common services, as it was referneced only from HDP-3.0. Slider 0.60.0.2.2 service definition still remains in common services, so it will be available for all the previous HDP stack definitions / other stack definitions.
- Miklos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63441/#review189818
-----------------------------------------------------------
On Oct. 31, 2017, 1:35 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63441/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 1:35 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-22340
> https://issues.apache.org/jira/browse/AMBARI-22340
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Slider is no longer a service on it's own in HDP 3.0, it is a part of YARN. So it should be removed from the stack definition.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml db490c9
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-client.xml adeba58
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-env.xml ce06a18
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-log4j.xml cd9b2a4
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/kerberos.json 8f07b42
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/metainfo.xml 168a2df
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/files/hbaseSmokeVerify.sh 5c320c0
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/__init__.py 5561e10
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params.py c03329c
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_linux.py 350be45
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_windows.py fd2f358
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/service_check.py 8582b5e
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider.py 83c5629
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider_client.py 45c7785
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/templates/storm-slider-env.sh.j2 8022a4b
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/service_advisor.py 5614868
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 061587d
> ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 23f558d
>
>
> Diff: https://reviews.apache.org/r/63441/diff/1/
>
>
> Testing
> -------
>
> Tested on local vagrant cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 63441: Remove Slider from Ambari stack definition
of HDP 3.0
Posted by Miklos Gergely <mg...@hortonworks.com>.
> On Nov. 1, 2017, 5:14 p.m., Jayush Luniya wrote:
> > This will break HIVE LLAP as it uses slider. Please don't make any changes to HDP-3.0 stack for now.
Currently there is no Slider package in the HDP-3.0 yum repos, so even if this dependency is still there it is impossible to install Hive with Ambari, as Slider can not be installed for HDP-3.0, the Ambari install will fail at the point when it looks for the Slider packages.
- Miklos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63441/#review189818
-----------------------------------------------------------
On Oct. 31, 2017, 1:35 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63441/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 1:35 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-22340
> https://issues.apache.org/jira/browse/AMBARI-22340
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Slider is no longer a service on it's own in HDP 3.0, it is a part of YARN. So it should be removed from the stack definition.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml db490c9
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-client.xml adeba58
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-env.xml ce06a18
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-log4j.xml cd9b2a4
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/kerberos.json 8f07b42
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/metainfo.xml 168a2df
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/files/hbaseSmokeVerify.sh 5c320c0
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/__init__.py 5561e10
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params.py c03329c
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_linux.py 350be45
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_windows.py fd2f358
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/service_check.py 8582b5e
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider.py 83c5629
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider_client.py 45c7785
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/templates/storm-slider-env.sh.j2 8022a4b
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/service_advisor.py 5614868
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 061587d
> ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 23f558d
>
>
> Diff: https://reviews.apache.org/r/63441/diff/1/
>
>
> Testing
> -------
>
> Tested on local vagrant cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>