You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/22 09:12:52 UTC

[GitHub] [dubbo-go-pixiu] ztelur opened a new pull request #242: Pixiu Config

ztelur opened a new pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242


   <!--  Thanks for sending a pull request! 
   -->
   
   **What this PR does**:
   - merge the pr Make filter configurable & Centralized management from mark4z
   - create Plugin, HttpFilter(such as ratelimit), NetworkFilter(such as httpconnectionmanager) and Adapter(such as cloud cloud adapter to control cluster and router ) abstraction, all extension will registered at pluginregistry.go 
   - move api_config and dubbo/http client to remote filter and api_config filter which offer special route strategy and dubbo proxy
   - create RouteManager、ClusterManager and common router strategy base on model.Router
   -  split server run to init and run two phase
   
   
   **Special notes for your reviewer**:
   - [plugin registry](https://github.com/ztelur/dubbo-go-pixiu/blob/config/pkg/pluginregistry/registry.go)
   - [Plugin and HttpFilter NetworkFilter](https://github.com/ztelur/dubbo-go-pixiu/blob/config/pkg/common/extension/filter/filter.go)
   - [Plugin and Adapter](https://github.com/ztelur/dubbo-go-pixiu/blob/config/pkg/common/extension/adapter/adapter.go)
   - [FilterManager](https://github.com/ztelur/dubbo-go-pixiu/blob/config/pkg/common/extension/filter/filter_manager.go)
   - [ClusterManager](https://github.com/ztelur/dubbo-go-pixiu/blob/config/pkg/server/cluster_manager.go)
   - [ListenerManager](https://github.com/ztelur/dubbo-go-pixiu/blob/config/pkg/server/listener_manager.go)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b856264) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **decrease** coverage by `2.22%`.
   > The diff coverage is `29.62%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   - Coverage    40.58%   38.36%   -2.23%     
   ===========================================
     Files           39       48       +9     
     Lines         2267     2513     +246     
   ===========================================
   + Hits           920      964      +44     
   - Misses        1255     1445     +190     
   - Partials        92      104      +12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `23.01% <0.00%> (-0.19%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [46 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...b856264](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4136f63) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **increase** coverage by `0.35%`.
   > The diff coverage is `40.56%`.
   
   > :exclamation: Current head 4136f63 differs from pull request most recent head 9bc5129. Consider uploading reports for the commit 9bc5129 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   + Coverage    40.58%   40.93%   +0.35%     
   ===========================================
     Files           39       51      +12     
     Lines         2267     2587     +320     
   ===========================================
   + Hits           920     1059     +139     
   - Misses        1255     1415     +160     
   - Partials        92      113      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `22.83% <0.00%> (-0.37%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [52 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...9bc5129](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] ztelur commented on a change in pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

ztelur commented on a change in pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#discussion_r696619954



##########
File path: pkg/config/config_load_test.go
##########
@@ -36,6 +37,56 @@ var b model.Bootstrap
 
 func TestMain(m *testing.M) {
 	log.Println("Prepare Bootstrap")
+
+	hcmc := model.HttpConnectionManager{
+		RouteConfig: model.RouteConfiguration{
+			Routes: []*model.Router{
+				{
+					ID: "1",
+					Match: model.RouterMatch{
+						Prefix: "/api/v1",
+						Methods: []string{
+							"POST",
+						},
+						Path:  "",
+						Regex: "",
+						Headers: []model.HeaderMatcher{
+							{Name: "X-DGP-WAY",
+								Values: []string{"Dubbo"},
+								Regex:  false,
+							},
+						},
+					},
+					Route: model.RouteAction{
+						Cluster:                     "test_dubbo",
+						ClusterNotFoundResponseCode: 505,
+					},
+				},
+			},
+			Dynamic: false,
+		},
+		HTTPFilters: []*model.HTTPFilter{
+			{
+				Name:   "dgp.filters.http.api",
+				Config: nil,
+			},
+			{
+				Name:   "dgp.filters.http.router",
+				Config: nil,
+			},
+			{
+				Name:   "dgp.filters.http_transfer_dubbo",

Review comment:
       看着早期 filter 的名称很多都是下划线开头的，可能是受到 envoy 中 filter 名称的影响 😂 
   ![image](https://user-images.githubusercontent.com/6263372/130968708-44b23793-18d9-48b0-8f1e-55e2a67d109d.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9bc5129) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **increase** coverage by `0.35%`.
   > The diff coverage is `40.56%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   + Coverage    40.58%   40.93%   +0.35%     
   ===========================================
     Files           39       51      +12     
     Lines         2267     2587     +320     
   ===========================================
   + Hits           920     1059     +139     
   - Misses        1255     1415     +160     
   - Partials        92      113      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `22.83% <0.00%> (-0.37%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [52 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...9bc5129](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

AlexStocks commented on a change in pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#discussion_r696205543



##########
File path: pkg/common/extension/filter/filter.go
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package filter
+
+import (
+	"fmt"
+)
+
+import (
+	"github.com/pkg/errors"
+)
+
+import (
+	"github.com/apache/dubbo-go-pixiu/pkg/context/http"
+	"github.com/apache/dubbo-go-pixiu/pkg/model"
+)
+
+type (
+	// HttpFilterPlugin describe plugin
+	HttpFilterPlugin interface {
+		// Kind returns the unique kind name to represent itself.
+		Kind() string
+
+		// CreateFilter return the filter callback
+		CreateFilter() (HttpFilter, error)
+	}
+
+	// HttpFilter describe http filter
+	HttpFilter interface {
+		// PrepareFilterChain add filter into chain
+		PrepareFilterChain(ctx *http.HttpContext) error
+
+		// Handle filter hook function
+		Handle(ctx *http.HttpContext)
+
+		Apply() error
+
+		// Config get config for filter
+		Config() interface{}
+	}
+
+	// NetworkFilter describe network filter plugin
+	NetworkFilterPlugin interface {
+		// Kind returns the unique kind name to represent itself.
+		Kind() string
+		// CreateFilterFactory return the filter callback
+		CreateFilter(config interface{}, bs *model.Bootstrap) (NetworkFilter, error)
+	}
+
+	// NetworkFilter describe network filter
+	NetworkFilter interface {
+		// OnData handle the http context from worker
+		OnData(hc *http.HttpContext) error
+	}
+)
+
+var (
+	httpFilterPluginRegistry    = map[string]HttpFilterPlugin{}
+	networkFilterPluginRegistry = map[string]NetworkFilterPlugin{}
+)
+
+// Register registers filter plugin.
+func RegisterHttpFilter(f HttpFilterPlugin) {
+	if f.Kind() == "" {
+		panic(fmt.Errorf("%T: empty kind", f))
+	}
+
+	existedPlugin, existed := httpFilterPluginRegistry[f.Kind()]
+	if existed {
+		panic(fmt.Errorf("%T and %T got same kind: %s", f, existedPlugin, f.Kind()))
+	}
+
+	httpFilterPluginRegistry[f.Kind()] = f
+}
+
+// GetHttpFilterPlugin get plugin by kind
+func GetHttpFilterPlugin(kind string) (HttpFilterPlugin, error) {
+	existedFilter, existed := httpFilterPluginRegistry[kind]
+	if existed {
+		return existedFilter, nil
+	} else {
+		return nil, errors.Errorf("plugin not found %s", kind)
+	}

Review comment:
       统一回复：
   ```go
   if existed {
   		return existedFilter, nil
   	} else {
   		return nil, errors.Errorf("plugin not found %s", kind)
   	}
   ```
   这种代码统一改为：
   ```go
            if existed {
   		return existedFilter, nil
   	} 
   	return nil, errors.Errorf("plugin not found %s", kind)
   ```	




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bdf4f6) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **increase** coverage by `0.30%`.
   > The diff coverage is `40.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   + Coverage    40.58%   40.88%   +0.30%     
   ===========================================
     Files           39       51      +12     
     Lines         2267     2590     +323     
   ===========================================
   + Hits           920     1059     +139     
   - Misses        1255     1416     +161     
   - Partials        92      115      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `22.83% <0.00%> (-0.37%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [52 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...1bdf4f6](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3acb508) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **increase** coverage by `0.30%`.
   > The diff coverage is `40.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   + Coverage    40.58%   40.88%   +0.30%     
   ===========================================
     Files           39       51      +12     
     Lines         2267     2590     +323     
   ===========================================
   + Hits           920     1059     +139     
   - Misses        1255     1416     +161     
   - Partials        92      115      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `22.83% <0.00%> (-0.37%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [52 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...3acb508](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

AlexStocks commented on a change in pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#discussion_r696206087



##########
File path: pkg/config/config_load_test.go
##########
@@ -36,6 +37,56 @@ var b model.Bootstrap
 
 func TestMain(m *testing.M) {
 	log.Println("Prepare Bootstrap")
+
+	hcmc := model.HttpConnectionManager{
+		RouteConfig: model.RouteConfiguration{
+			Routes: []*model.Router{
+				{
+					ID: "1",
+					Match: model.RouterMatch{
+						Prefix: "/api/v1",
+						Methods: []string{
+							"POST",
+						},
+						Path:  "",
+						Regex: "",
+						Headers: []model.HeaderMatcher{
+							{Name: "X-DGP-WAY",
+								Values: []string{"Dubbo"},
+								Regex:  false,
+							},
+						},
+					},
+					Route: model.RouteAction{
+						Cluster:                     "test_dubbo",
+						ClusterNotFoundResponseCode: 505,
+					},
+				},
+			},
+			Dynamic: false,
+		},
+		HTTPFilters: []*model.HTTPFilter{
+			{
+				Name:   "dgp.filters.http.api",
+				Config: nil,
+			},
+			{
+				Name:   "dgp.filters.http.router",
+				Config: nil,
+			},
+			{
+				Name:   "dgp.filters.http_transfer_dubbo",

Review comment:
       你的很多配置中method或者class用了下划线，java和go都没有这种命名风格啊？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (99a6296) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/f668fe049d9fbd799d4cee5a531e255b64bce2e4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f668fe0) will **increase** coverage by `0.37%`.
   > The diff coverage is `40.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   + Coverage    40.56%   40.93%   +0.37%     
   ===========================================
     Files           39       51      +12     
     Lines         2283     2587     +304     
   ===========================================
   + Hits           926     1059     +133     
   - Misses        1267     1415     +148     
   - Partials        90      113      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `22.83% <0.00%> (-0.37%)` | :arrow_down: |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lcl9tYW5hZ2VyLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/otel.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9vdGVsLmdv) | `0.00% <ø> (ø)` | |
   | ... and [43 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f668fe0...99a6296](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bdf4f6) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **increase** coverage by `0.30%`.
   > The diff coverage is `40.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   + Coverage    40.58%   40.88%   +0.30%     
   ===========================================
     Files           39       51      +12     
     Lines         2267     2590     +323     
   ===========================================
   + Hits           920     1059     +139     
   - Misses        1255     1416     +161     
   - Partials        92      115      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `22.83% <0.00%> (-0.37%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [52 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...1bdf4f6](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

AlexStocks merged pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e145af) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **decrease** coverage by `2.22%`.
   > The diff coverage is `29.62%`.
   
   > :exclamation: Current head 9e145af differs from pull request most recent head b856264. Consider uploading reports for the commit b856264 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   - Coverage    40.58%   38.36%   -2.23%     
   ===========================================
     Files           39       48       +9     
     Lines         2267     2513     +246     
   ===========================================
   + Hits           920      964      +44     
   - Misses        1255     1445     +190     
   - Partials        92      104      +12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `23.01% <0.00%> (-0.19%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [46 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...b856264](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

AlexStocks commented on a change in pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#discussion_r696203868



##########
File path: configs/api_config.yaml
##########
@@ -22,67 +22,85 @@ resources:
   - path: '/api/v1/test-dubbo/user'
     type: restful
     description: user
-    timeout: 100ms
     methods:
-      - httpVerb: GET
+      - httpVerb: POST
         onAir: true
-        timeout: 1000ms
+        timeout: 100s

Review comment:
       这么长时间的超时，在生产环境基本就不可用




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f75c886) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **decrease** coverage by `2.25%`.
   > The diff coverage is `29.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   - Coverage    40.58%   38.33%   -2.26%     
   ===========================================
     Files           39       48       +9     
     Lines         2267     2515     +248     
   ===========================================
   + Hits           920      964      +44     
   - Misses        1255     1447     +192     
   - Partials        92      104      +12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `23.01% <0.00%> (-0.19%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [46 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...f75c886](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

AlexStocks commented on a change in pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#discussion_r696204765



##########
File path: pkg/client/dubbo/dubbo.go
##########
@@ -68,6 +68,7 @@ var (
 type Client struct {
 	lock               sync.RWMutex
 	GenericServicePool map[string]*dg.GenericService
+	dpc                *DubboProxyConfig

Review comment:
       还不如命名为 dubboProxyConfig，dpc有人能望文生义么？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a0fb076) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **increase** coverage by `0.30%`.
   > The diff coverage is `40.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   + Coverage    40.58%   40.88%   +0.30%     
   ===========================================
     Files           39       51      +12     
     Lines         2267     2590     +323     
   ===========================================
   + Hits           920     1059     +139     
   - Misses        1255     1416     +161     
   - Partials        92      115      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `22.83% <0.00%> (-0.37%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [52 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...a0fb076](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f75c886) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **decrease** coverage by `2.25%`.
   > The diff coverage is `29.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   - Coverage    40.58%   38.33%   -2.26%     
   ===========================================
     Files           39       48       +9     
     Lines         2267     2515     +248     
   ===========================================
   + Hits           920      964      +44     
   - Misses        1255     1447     +192     
   - Partials        92      104      +12     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `23.01% <0.00%> (-0.19%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [46 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...f75c886](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] ztelur commented on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

ztelur commented on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903754006


   I will add more unit test and integration test later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #242: Pixiu Config

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #242:
URL: https://github.com/apache/dubbo-go-pixiu/pull/242#issuecomment-903749972


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#242](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b3c4226) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/86575cd2e1821345b3d67822a9a48adbb51d27d2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86575cd) will **increase** coverage by `0.30%`.
   > The diff coverage is `40.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #242      +/-   ##
   ===========================================
   + Coverage    40.58%   40.88%   +0.30%     
   ===========================================
     Files           39       51      +12     
     Lines         2267     2590     +323     
   ===========================================
   + Hits           920     1059     +139     
   - Misses        1255     1416     +161     
   - Partials        92      115      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `22.83% <0.00%> (-0.37%)` | :arrow_down: |
   | [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (ø)` | |
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `47.94% <0.00%> (ø)` | |
   | [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (ø)` | |
   | [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (ø)` | |
   | [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-30.15%)` | :arrow_down: |
   | [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <ø> (+0.34%)` | :arrow_up: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
   | [pkg/filter/accesslog/log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvbG9nLmdv) | `43.13% <ø> (ø)` | |
   | [pkg/filter/ratelimit/logger\_warpper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvbG9nZ2VyX3dhcnBwZXIuZ28=) | `11.11% <ø> (ø)` | |
   | ... and [52 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [86575cd...b3c4226](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/242?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org