You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2026/06/29 11:19:27 UTC

[PR] disable the lifecycle metrics collector if the container has disabled [skywalking-banyandb-helm]

mrproliu opened a new pull request, #64:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/64

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] disable the lifecycle metrics collector if the container has disabled [skywalking-banyandb-helm]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #64:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/64#discussion_r3491291773


##########
CHANGES.md:
##########
@@ -10,6 +10,7 @@ Release Notes.
 - Remove etcd support (breaking change).
   If upgrading, remove `etcd-client.*` and `cluster.*.tls.etcdSecretName`
   from your values overrides.
+- Disable the lifecycle metrics collector if the container has disabled.

Review Comment:
   Grammar in the release note is incorrect/unclear (“has disabled”). Consider rephrasing to clearly refer to the lifecycle sidecar container being disabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org