You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Michael Freedman (JIRA)" <de...@myfaces.apache.org> on 2007/11/30 19:41:42 UTC

[jira] Created: (PORTLETBRIDGE-18) ExternalContext.getViewIdFromPath missing an else statement

ExternalContext.getViewIdFromPath missing an else statement
-----------------------------------------------------------

                 Key: PORTLETBRIDGE-18
                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-18
             Project: MyFaces Portlet Bridge
          Issue Type: Bug
          Components: Impl
    Affects Versions: 1.0.0-SNAPSHOT
            Reporter: Michael Freedman
             Fix For: 1.0.0-SNAPSHOT


Code in EC.getViewIdFromPath is missing an else clause causing us to drop the suffix translation.  I.e. code should have an else before the if (isPrefixedMapped) --inserted code (else) is in all caps:
    // Okay now figure out whether this is prefix or suffixed mapped
    if (isSuffixedMapped(url, mFacesMappings))
    {
      viewId = viewIdFromSuffixMapping(
                                       url,
                                       mFacesMappings,
                                       mPortletContext
                                                      .getInitParameter(ViewHandler.DEFAULT_SUFFIX_PARAM_NAME));
    }
  ELSE if (isPrefixedMapped(url, mFacesMappings))
    {
      viewId = viewIdFromPrefixMapping(url, mFacesMappings);
    }
    else
    {
      // Set to what follows the URL
      viewId = url;
    }
    return viewId;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PORTLETBRIDGE-18) ExternalContext.getViewIdFromPath missing an else statement

Posted by "Michael Freedman (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Freedman updated PORTLETBRIDGE-18:
------------------------------------------

    Status: Patch Available  (was: Open)

> ExternalContext.getViewIdFromPath missing an else statement
> -----------------------------------------------------------
>
>                 Key: PORTLETBRIDGE-18
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-18
>             Project: MyFaces Portlet Bridge
>          Issue Type: Bug
>          Components: Impl
>    Affects Versions: 1.0.0-SNAPSHOT
>            Reporter: Michael Freedman
>             Fix For: 1.0.0-SNAPSHOT
>
>         Attachments: externalcontext_path.patch
>
>
> Code in EC.getViewIdFromPath is missing an else clause causing us to drop the suffix translation.  I.e. code should have an else before the if (isPrefixedMapped) --inserted code (else) is in all caps:
>     // Okay now figure out whether this is prefix or suffixed mapped
>     if (isSuffixedMapped(url, mFacesMappings))
>     {
>       viewId = viewIdFromSuffixMapping(
>                                        url,
>                                        mFacesMappings,
>                                        mPortletContext
>                                                       .getInitParameter(ViewHandler.DEFAULT_SUFFIX_PARAM_NAME));
>     }
>   ELSE if (isPrefixedMapped(url, mFacesMappings))
>     {
>       viewId = viewIdFromPrefixMapping(url, mFacesMappings);
>     }
>     else
>     {
>       // Set to what follows the URL
>       viewId = url;
>     }
>     return viewId;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PORTLETBRIDGE-18) ExternalContext.getViewIdFromPath missing an else statement

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated PORTLETBRIDGE-18:
--------------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Thx to Michael Freedman

> ExternalContext.getViewIdFromPath missing an else statement
> -----------------------------------------------------------
>
>                 Key: PORTLETBRIDGE-18
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-18
>             Project: MyFaces Portlet Bridge
>          Issue Type: Bug
>          Components: Impl
>    Affects Versions: 1.0.0-SNAPSHOT
>            Reporter: Michael Freedman
>             Fix For: 1.0.0-SNAPSHOT
>
>         Attachments: externalcontext_path.patch
>
>
> Code in EC.getViewIdFromPath is missing an else clause causing us to drop the suffix translation.  I.e. code should have an else before the if (isPrefixedMapped) --inserted code (else) is in all caps:
>     // Okay now figure out whether this is prefix or suffixed mapped
>     if (isSuffixedMapped(url, mFacesMappings))
>     {
>       viewId = viewIdFromSuffixMapping(
>                                        url,
>                                        mFacesMappings,
>                                        mPortletContext
>                                                       .getInitParameter(ViewHandler.DEFAULT_SUFFIX_PARAM_NAME));
>     }
>   ELSE if (isPrefixedMapped(url, mFacesMappings))
>     {
>       viewId = viewIdFromPrefixMapping(url, mFacesMappings);
>     }
>     else
>     {
>       // Set to what follows the URL
>       viewId = url;
>     }
>     return viewId;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.