You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/11/07 06:27:34 UTC

[kudu-CR] [cfile] not null -> is null 

lingbinlb@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14651


Change subject: [cfile] not_null -> is_null
......................................................................

[cfile] not_null -> is_null

In a bitmap, we use `true` to represent `null`. So when we iterate
over a bitmap, if it returns `true`, its meaning is "it is a null"

In the original implementation, it was incorrectly named `not_null`

Change-Id: I836ebce2eae6f8df18ec256b000fee23fd62ce3e
---
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
2 files changed, 11 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/14651/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I836ebce2eae6f8df18ec256b000fee23fd62ce3e
Gerrit-Change-Number: 14651
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>

[kudu-CR] [cfile] not null -> is null

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14651 )

Change subject: [cfile] not_null -> is_null
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I836ebce2eae6f8df18ec256b000fee23fd62ce3e
Gerrit-Change-Number: 14651
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 07 Nov 2019 16:54:34 +0000
Gerrit-HasComments: No

[kudu-CR] [cfile] not null -> is null

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14651

to look at the new patch set (#2).

Change subject: [cfile] not_null -> is_null
......................................................................

[cfile] not_null -> is_null

In a bitmap, we use `true` to represent `null`. So when we iterate
over a bitmap, if it returns `true`, its meaning is "it is a null"

In the original implementation, it was incorrectly named `not_null`

Change-Id: I836ebce2eae6f8df18ec256b000fee23fd62ce3e
---
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
2 files changed, 11 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/14651/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I836ebce2eae6f8df18ec256b000fee23fd62ce3e
Gerrit-Change-Number: 14651
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [cfile] not null -> is null

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14651 )

Change subject: [cfile] not_null -> is_null
......................................................................

[cfile] not_null -> is_null

In a bitmap, we use `true` to represent `null`. So when we iterate
over a bitmap, if it returns `true`, its meaning is "it is a null"

In the original implementation, it was incorrectly named `not_null`

Change-Id: I836ebce2eae6f8df18ec256b000fee23fd62ce3e
Reviewed-on: http://gerrit.cloudera.org:8080/14651
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
2 files changed, 11 insertions(+), 10 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I836ebce2eae6f8df18ec256b000fee23fd62ce3e
Gerrit-Change-Number: 14651
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)