[GitHub] [superset] amitmiran137 commented on a change in pull request #13773: feat(dashboard_rbac): dashboard extra jwt

[GitBox <gi...@apache.org>]

amitmiran137 commented on a change in pull request #13773:
URL: https://github.com/apache/superset/pull/13773#discussion_r605210362



##########
File path: superset/views/core.py
##########
@@ -1869,6 +1875,19 @@ def dashboard(  # pylint: disable=too-many-locals
             if key not in [param.value for param in utils.ReservedUrlParameters]
         }
 
+        extra_jwt = {}
+        if feature_flag_manager.is_feature_enabled("DASHBOARD_RBAC"):

Review comment:
       Ok so the jwt is being used to manage read data access of charts that exists on a dashboard implicitly just by having a access to the dashboard
   
   This really upgrade the dashboard access RBAC mechanism by also giving Temporary access to datasets that are being used within the dash lard without the need to explicitly giving permission to those datasets
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org