You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Thomas Neidhart <th...@gmail.com> on 2014/10/15 17:05:01 UTC

Re: svn commit: r1632060 - /commons/proper/email/trunk/src/changes/changes.xml

Hi Gary,

thanks for the changes, but see my comments below:

On Wed, Oct 15, 2014 at 4:44 PM, <gg...@apache.org> wrote:

> Author: ggregory
> Date: Wed Oct 15 14:44:54 2014
> New Revision: 1632060
>
> URL: http://svn.apache.org/r1632060
> Log:
> [EMAIL-143] Update Apache Commons Logging from 1.1.3 to 1.2.
>

I failed to find any dependency to commons logging and I have also not seen
a commit from you that bumped the version from 1.1.3 to 1.2 anywhere in the
codebase.
Do I miss there something or was this a mistake?


> [EMAIL-144] Update Oracle Mail from 1.4.5 to 1.5.2.
>

ok, if you update to javamail 1.5.2 we should probably bump the version to
1.4.


> [EMAIL-145] Update slf4j-jdk14 from 1.6.1 to 1.7.7.
>

thats just a test dependency, I would not create a ticket for it and
mention it in the release notes.


>
> Modified:
>     commons/proper/email/trunk/src/changes/changes.xml
>
> Modified: commons/proper/email/trunk/src/changes/changes.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/email/trunk/src/changes/changes.xml?rev=1632060&r1=1632059&r2=1632060&view=diff
>
> ==============================================================================
> --- commons/proper/email/trunk/src/changes/changes.xml (original)
> +++ commons/proper/email/trunk/src/changes/changes.xml Wed Oct 15 14:44:54
> 2014
> @@ -30,6 +30,15 @@
>        <action dev="tn" type="add" issue="EMAIL-141" date="2014-09-14"
> due-to="Stephen Kruger">
>          Added support for mapping of content-ids to DataSource in
> "MimeMessageParser".
>        </action>
> +      <action dev="ggregory" type="update" issue="EMAIL-143"
> date="2014-10-15">
> +        Update Apache Commons Logging from 1.1.3 to 1.2.
> +      </action>
> +      <action dev="ggregory" type="update" issue="EMAIL-144"
> date="2014-10-15">
> +        Update Oracle Mail from 1.4.5 to 1.5.2.
> +      </action>
> +      <action dev="ggregory" type="update" issue="EMAIL-145"
> date="2014-10-15">
> +        Update slf4j-jdk14 from 1.6.1 to 1.7.7.
> +      </action>
>      </release>
>      <release version="1.3.3" date="2014-07-12">
>        <action dev="tn" type="fix" issue="EMAIL-140" date="2014-07-01"
> due-to="Gary Gregory">
>
>
>

Re: svn commit: r1632060 - /commons/proper/email/trunk/src/changes/changes.xml

Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Oct 15, 2014 at 11:35 AM, Thomas Neidhart <thomas.neidhart@gmail.com
> wrote:

> On Wed, Oct 15, 2014 at 5:14 PM, Gary Gregory <ga...@gmail.com>
> wrote:
>
> > On Wed, Oct 15, 2014 at 11:05 AM, Thomas Neidhart <
> > thomas.neidhart@gmail.com
> > > wrote:
> >
> > > Hi Gary,
> > >
> > > thanks for the changes, but see my comments below:
> > >
> > > On Wed, Oct 15, 2014 at 4:44 PM, <gg...@apache.org> wrote:
> > >
> > > > Author: ggregory
> > > > Date: Wed Oct 15 14:44:54 2014
> > > > New Revision: 1632060
> > > >
> > > > URL: http://svn.apache.org/r1632060
> > > > Log:
> > > > [EMAIL-143] Update Apache Commons Logging from 1.1.3 to 1.2.
> > > >
> > >
> > > I failed to find any dependency to commons logging and I have also not
> > seen
> > > a commit from you that bumped the version from 1.1.3 to 1.2 anywhere in
> > the
> > > codebase.
> > > Do I miss there something or was this a mistake?
> >
>
> what about this change?
>

Arg, fixed, good catch, thank you. Delete the JIRA too.

Gary

>
>
> > >
> > >
> > > > [EMAIL-144] Update Oracle Mail from 1.4.5 to 1.5.2.
> > > >
> > >
> > > ok, if you update to javamail 1.5.2 we should probably bump the version
> > to
> > > 1.4.
> > >
> >
> > Done.
> >
> >
> > >
> > >
> > > > [EMAIL-145] Update slf4j-jdk14 from 1.6.1 to 1.7.7.
> > > >
> > >
> > > thats just a test dependency, I would not create a ticket for it and
> > > mention it in the release notes.
> > >
> >
> > Removed from changes.xml. Not worth deleting the JIRA though.
> >
>
> ok thanks,
>
> Thomas
>
>
>
> > Thank you for the review.
> >
> > Gary
> >
> > >
> > >
> > > >
> > > > Modified:
> > > >     commons/proper/email/trunk/src/changes/changes.xml
> > > >
> > > > Modified: commons/proper/email/trunk/src/changes/changes.xml
> > > > URL:
> > > >
> > >
> >
> http://svn.apache.org/viewvc/commons/proper/email/trunk/src/changes/changes.xml?rev=1632060&r1=1632059&r2=1632060&view=diff
> > > >
> > > >
> > >
> >
> ==============================================================================
> > > > --- commons/proper/email/trunk/src/changes/changes.xml (original)
> > > > +++ commons/proper/email/trunk/src/changes/changes.xml Wed Oct 15
> > > 14:44:54
> > > > 2014
> > > > @@ -30,6 +30,15 @@
> > > >        <action dev="tn" type="add" issue="EMAIL-141"
> date="2014-09-14"
> > > > due-to="Stephen Kruger">
> > > >          Added support for mapping of content-ids to DataSource in
> > > > "MimeMessageParser".
> > > >        </action>
> > > > +      <action dev="ggregory" type="update" issue="EMAIL-143"
> > > > date="2014-10-15">
> > > > +        Update Apache Commons Logging from 1.1.3 to 1.2.
> > > > +      </action>
> > > > +      <action dev="ggregory" type="update" issue="EMAIL-144"
> > > > date="2014-10-15">
> > > > +        Update Oracle Mail from 1.4.5 to 1.5.2.
> > > > +      </action>
> > > > +      <action dev="ggregory" type="update" issue="EMAIL-145"
> > > > date="2014-10-15">
> > > > +        Update slf4j-jdk14 from 1.6.1 to 1.7.7.
> > > > +      </action>
> > > >      </release>
> > > >      <release version="1.3.3" date="2014-07-12">
> > > >        <action dev="tn" type="fix" issue="EMAIL-140"
> date="2014-07-01"
> > > > due-to="Gary Gregory">
> > > >
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: svn commit: r1632060 - /commons/proper/email/trunk/src/changes/changes.xml

Posted by Thomas Neidhart <th...@gmail.com>.
On Wed, Oct 15, 2014 at 5:14 PM, Gary Gregory <ga...@gmail.com>
wrote:

> On Wed, Oct 15, 2014 at 11:05 AM, Thomas Neidhart <
> thomas.neidhart@gmail.com
> > wrote:
>
> > Hi Gary,
> >
> > thanks for the changes, but see my comments below:
> >
> > On Wed, Oct 15, 2014 at 4:44 PM, <gg...@apache.org> wrote:
> >
> > > Author: ggregory
> > > Date: Wed Oct 15 14:44:54 2014
> > > New Revision: 1632060
> > >
> > > URL: http://svn.apache.org/r1632060
> > > Log:
> > > [EMAIL-143] Update Apache Commons Logging from 1.1.3 to 1.2.
> > >
> >
> > I failed to find any dependency to commons logging and I have also not
> seen
> > a commit from you that bumped the version from 1.1.3 to 1.2 anywhere in
> the
> > codebase.
> > Do I miss there something or was this a mistake?
>

what about this change?


> >
> >
> > > [EMAIL-144] Update Oracle Mail from 1.4.5 to 1.5.2.
> > >
> >
> > ok, if you update to javamail 1.5.2 we should probably bump the version
> to
> > 1.4.
> >
>
> Done.
>
>
> >
> >
> > > [EMAIL-145] Update slf4j-jdk14 from 1.6.1 to 1.7.7.
> > >
> >
> > thats just a test dependency, I would not create a ticket for it and
> > mention it in the release notes.
> >
>
> Removed from changes.xml. Not worth deleting the JIRA though.
>

ok thanks,

Thomas



> Thank you for the review.
>
> Gary
>
> >
> >
> > >
> > > Modified:
> > >     commons/proper/email/trunk/src/changes/changes.xml
> > >
> > > Modified: commons/proper/email/trunk/src/changes/changes.xml
> > > URL:
> > >
> >
> http://svn.apache.org/viewvc/commons/proper/email/trunk/src/changes/changes.xml?rev=1632060&r1=1632059&r2=1632060&view=diff
> > >
> > >
> >
> ==============================================================================
> > > --- commons/proper/email/trunk/src/changes/changes.xml (original)
> > > +++ commons/proper/email/trunk/src/changes/changes.xml Wed Oct 15
> > 14:44:54
> > > 2014
> > > @@ -30,6 +30,15 @@
> > >        <action dev="tn" type="add" issue="EMAIL-141" date="2014-09-14"
> > > due-to="Stephen Kruger">
> > >          Added support for mapping of content-ids to DataSource in
> > > "MimeMessageParser".
> > >        </action>
> > > +      <action dev="ggregory" type="update" issue="EMAIL-143"
> > > date="2014-10-15">
> > > +        Update Apache Commons Logging from 1.1.3 to 1.2.
> > > +      </action>
> > > +      <action dev="ggregory" type="update" issue="EMAIL-144"
> > > date="2014-10-15">
> > > +        Update Oracle Mail from 1.4.5 to 1.5.2.
> > > +      </action>
> > > +      <action dev="ggregory" type="update" issue="EMAIL-145"
> > > date="2014-10-15">
> > > +        Update slf4j-jdk14 from 1.6.1 to 1.7.7.
> > > +      </action>
> > >      </release>
> > >      <release version="1.3.3" date="2014-07-12">
> > >        <action dev="tn" type="fix" issue="EMAIL-140" date="2014-07-01"
> > > due-to="Gary Gregory">
> > >
> > >
> > >
> >
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>

Re: svn commit: r1632060 - /commons/proper/email/trunk/src/changes/changes.xml

Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Oct 15, 2014 at 11:05 AM, Thomas Neidhart <thomas.neidhart@gmail.com
> wrote:

> Hi Gary,
>
> thanks for the changes, but see my comments below:
>
> On Wed, Oct 15, 2014 at 4:44 PM, <gg...@apache.org> wrote:
>
> > Author: ggregory
> > Date: Wed Oct 15 14:44:54 2014
> > New Revision: 1632060
> >
> > URL: http://svn.apache.org/r1632060
> > Log:
> > [EMAIL-143] Update Apache Commons Logging from 1.1.3 to 1.2.
> >
>
> I failed to find any dependency to commons logging and I have also not seen
> a commit from you that bumped the version from 1.1.3 to 1.2 anywhere in the
> codebase.
> Do I miss there something or was this a mistake?
>
>
> > [EMAIL-144] Update Oracle Mail from 1.4.5 to 1.5.2.
> >
>
> ok, if you update to javamail 1.5.2 we should probably bump the version to
> 1.4.
>

Done.


>
>
> > [EMAIL-145] Update slf4j-jdk14 from 1.6.1 to 1.7.7.
> >
>
> thats just a test dependency, I would not create a ticket for it and
> mention it in the release notes.
>

Removed from changes.xml. Not worth deleting the JIRA though.

Thank you for the review.

Gary

>
>
> >
> > Modified:
> >     commons/proper/email/trunk/src/changes/changes.xml
> >
> > Modified: commons/proper/email/trunk/src/changes/changes.xml
> > URL:
> >
> http://svn.apache.org/viewvc/commons/proper/email/trunk/src/changes/changes.xml?rev=1632060&r1=1632059&r2=1632060&view=diff
> >
> >
> ==============================================================================
> > --- commons/proper/email/trunk/src/changes/changes.xml (original)
> > +++ commons/proper/email/trunk/src/changes/changes.xml Wed Oct 15
> 14:44:54
> > 2014
> > @@ -30,6 +30,15 @@
> >        <action dev="tn" type="add" issue="EMAIL-141" date="2014-09-14"
> > due-to="Stephen Kruger">
> >          Added support for mapping of content-ids to DataSource in
> > "MimeMessageParser".
> >        </action>
> > +      <action dev="ggregory" type="update" issue="EMAIL-143"
> > date="2014-10-15">
> > +        Update Apache Commons Logging from 1.1.3 to 1.2.
> > +      </action>
> > +      <action dev="ggregory" type="update" issue="EMAIL-144"
> > date="2014-10-15">
> > +        Update Oracle Mail from 1.4.5 to 1.5.2.
> > +      </action>
> > +      <action dev="ggregory" type="update" issue="EMAIL-145"
> > date="2014-10-15">
> > +        Update slf4j-jdk14 from 1.6.1 to 1.7.7.
> > +      </action>
> >      </release>
> >      <release version="1.3.3" date="2014-07-12">
> >        <action dev="tn" type="fix" issue="EMAIL-140" date="2014-07-01"
> > due-to="Gary Gregory">
> >
> >
> >
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory