You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/06 19:43:15 UTC

[GitHub] nswamy commented on issue #9771: Modify NDArrayIter constructor to receive tuple (i.e. dict in Python)…

nswamy commented on issue #9771: Modify NDArrayIter constructor to receive tuple (i.e. dict in Python)…
URL: https://github.com/apache/incubator-mxnet/pull/9771#issuecomment-410829667
 
 
   Sorry had missed this PR, this is already handled by another PR https://github.com/apache/incubator-mxnet/blob/master/scala-package/core/src/main/scala/org/apache/mxnet/io/NDArrayIter.scala#L42.
   and 
   https://github.com/apache/incubator-mxnet/blob/master/scala-package/core/src/main/scala/org/apache/mxnet/io/NDArrayIter.scala#L59
   
   Like the author mentioned there is no other way than modifying primary constructor, since all secondary constructors have to call the primary constructor. However API compatibility is still maintained since we have secondary constructors that keep the parameters from the original constructor. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services