You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/11/12 15:34:25 UTC
[GitHub] [calcite] pavelgubin commented on a change in pull request #1271:
[CALCITE-3112] Support Window in RelToSqlConverter
pavelgubin commented on a change in pull request #1271: [CALCITE-3112] Support Window in RelToSqlConverter
URL: https://github.com/apache/calcite/pull/1271#discussion_r345276348
##########
File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -1826,6 +1827,91 @@ private void checkLiteral2(String expression, String expected) {
sql(query).ok(expected);
}
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-3112">[CALCITE-3112]
+ * Support Window in RelToSqlConverter</a>. */
+ @Test public void testConvertWinodwToSql() {
+ String query0 = "SELECT row_number() over (order by \"hire_date\") FROM \"employee\"";
+ String expected0 = "SELECT ROW_NUMBER() OVER (ORDER BY \"hire_date\") AS \"$0\"\n"
+ + "FROM \"foodmart\".\"employee\"";
+
+ String query1 = "SELECT rank() over (order by \"hire_date\") FROM \"employee\"";
+ String expected1 = "SELECT RANK() OVER (ORDER BY \"hire_date\") AS \"$0\"\n"
+ + "FROM \"foodmart\".\"employee\"";
+
+ String query2 = "SELECT lead(\"employee_id\",1,'NA') over "
+ + "(partition by \"hire_date\" order by \"employee_id\")\n"
+ + "FROM \"employee\"";
+ String expected2 = "SELECT LEAD(\"employee_id\", 1, 'NA') OVER "
+ + "(PARTITION BY \"hire_date\" "
+ + "ORDER BY \"employee_id\") AS \"$0\"\n"
+ + "FROM \"foodmart\".\"employee\"";
+
+ String query3 = "SELECT lag(\"employee_id\",1,'NA') over "
+ + "(partition by \"hire_date\" order by \"employee_id\")\n"
+ + "FROM \"employee\"";
+ String expected3 = "SELECT LAG(\"employee_id\", 1, 'NA') OVER "
+ + "(PARTITION BY \"hire_date\" ORDER BY \"employee_id\") AS \"$0\"\n"
+ + "FROM \"foodmart\".\"employee\"";
+
+ String query4 = "SELECT lag(\"employee_id\",1,'NA') "
+ + "over (partition by \"hire_date\" order by \"employee_id\") as lag1, "
+ + "lag(\"employee_id\",1,'NA') "
+ + "over (partition by \"birth_date\" order by \"employee_id\") as lag2, "
+ + "count(*) over (partition by \"hire_date\" order by \"employee_id\") as count1, "
+ + "count(*) over (partition by \"birth_date\" order by \"employee_id\") as count2\n"
+ + "FROM \"employee\"";
+ String expected4 = "SELECT LAG(\"employee_id\", 1, 'NA') OVER "
+ + "(PARTITION BY \"hire_date\" ORDER BY \"employee_id\") AS \"$0\", "
+ + "LAG(\"employee_id\", 1, 'NA') OVER "
+ + "(PARTITION BY \"birth_date\" ORDER BY \"employee_id\") AS \"$1\", "
+ + "COUNT(*) OVER (PARTITION BY \"hire_date\" ORDER BY \"employee_id\" "
+ + "RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS \"$2\", "
+ + "COUNT(*) OVER (PARTITION BY \"birth_date\" ORDER BY \"employee_id\" "
+ + "RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS \"$3\"\n"
Review comment:
Yes, there is a problem here: https://github.com/apache/calcite/blob/dc34cd0ee7ed704a97242c0153c11d46b21c7b9a/core/src/main/java/org/apache/calcite/rel/rules/CalcRelSplitter.java#L235
Output row type (with correct aliases) is not propagated because LogicalCalc turns out to be trivial in these cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services