You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Guan-Ming Chiu (Jira)" <ji...@apache.org> on 2026/10/19 09:50:00 UTC

[jira] [Commented] (SPARK-54158) lock in ProfilerCollector is not really doing anything

    [ https://issues.apache.org/jira/browse/SPARK-54158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18128683#comment-18128683 ] 

Guan-Ming Chiu commented on SPARK-54158:
----------------------------------------

Hi [~gaogaotiantian] Could I help work on this? The writer seems never takes the lock in classic mode and show/dump release it before reading the shared Stats objects.

I think there are two options:
A. Make it thread-safe by having addInPlace and clear_* build new dicts instead of mutating, so readers hold a stable snapshot.
B. Drop the lock and document that the collector is not thread-safe.

I lean toward A since you mentioned continuous profiling. Does that sound right? Feel free to correct me if I have any misunderstanding, thanks!

> lock in ProfilerCollector is not really doing anything
> ------------------------------------------------------
>
>                 Key: SPARK-54158
>                 URL: https://issues.apache.org/jira/browse/SPARK-54158
>             Project: Spark
>          Issue Type: Bug
>          Components: PySpark
>    Affects Versions: 4.1.0
>            Reporter: Tian Gao
>            Priority: Major
>
> We had a lock in ProfilerCollector, but it's not really doing anything. It protects plenty of atomic operations like "stats = self._perf_profile_results", which is a shallow copy anyway. You'll still read and modify later.
> The whole code is still not thread-safe (the accumulator can just modify the result anytime without any locking mechanism).
> We need to decide whether we want it to be thread-safe (I assume we want for continuous profiling). If we do, we need to do it properly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org