You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org> on 2007/11/10 16:26:50 UTC
[jira] Updated: (TAPESTRY-1689) Tapestry portlets writes a lot of
comments into result html code
[ https://issues.apache.org/jira/browse/TAPESTRY-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAPESTRY-1689:
-------------------------------------------
Affects Version/s: 4.1.3
> Tapestry portlets writes a lot of comments into result html code
> ----------------------------------------------------------------
>
> Key: TAPESTRY-1689
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1689
> Project: Tapestry
> Issue Type: Bug
> Components: Portlet
> Affects Versions: 4.1.3
> Environment: tapestry portlet 4.0.2
> Reporter: Vitaly Baranovsky
> Priority: Minor
>
> Every portlet on page writes comments in result html code like:
> <!-- BEGIN Tapestry Portlet htmlPortlet js_P_111c70dfed8_10016_ -->
> <!-- Page: View -->
> <!-- Generated: Thu Aug 02 12:03:09 EEST 2007 -->
> <!-- Framework version: 4.0.2 -->
> then portlet html code, then:
> <!-- END Tapestry Portlet htmlPortlet js_P_111c70dfed8_10016_ -->
> So, if portal pages has about 50 portlets, only this comments occupies about 12Kbytes. This is bad for portal clients that connects to portal thru modems or for clients, that are paid for trafics (in our country people are paiying for every Mb of traffic very often). So, I think, this comments have to be optimized.
> So, it would be better to clean away this comments.
> This comments are hardcoded in PortletRendererImpl class (method public void renderPage(IRequestCycle cycle, String pageName)):
> writer.comment("BEGIN " + id);
> writer.comment("Page: " + page.getPageName());
> writer.comment("Generated: " + new Date());
> writer.comment("Framework version: " + Tapestry.VERSION);
>
> support.writeBodyScript(writer, cycle);
>
> nested.close();
>
> support.writeInitializationScript(writer);
>
> writer.comment("END " + id);
> I think it would be better to remove calls to method writer.comment, or make html comment of tapestry portlets configurable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org