You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/21 10:31:46 UTC
[GitHub] [arrow] liyafan82 commented on a change in pull request #6323: ARROW-7610: [Java] Finish support for 64 bit int allocations
liyafan82 commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r412067781
##########
File path: java/memory/src/main/java/org/apache/arrow/memory/NettyAllocationManager.java
##########
@@ -34,31 +33,24 @@
static final UnsafeDirectLittleEndian EMPTY = INNER_ALLOCATOR.empty;
static final long CHUNK_SIZE = INNER_ALLOCATOR.getChunkSize();
- private final int allocatedSize;
- private final UnsafeDirectLittleEndian memoryChunk;
+ private final long allocatedSize;
- NettyAllocationManager(BaseAllocator accountingAllocator, int requestedSize) {
- super(accountingAllocator);
- this.memoryChunk = INNER_ALLOCATOR.allocate(requestedSize);
Review comment:
Revised. Thank you for the good suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org