You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/02/04 01:29:09 UTC
[GitHub] [shardingsphere] wgy8283335 opened a new pull request #9306: feature: truncate table in oracle.
wgy8283335 opened a new pull request #9306:
URL: https://github.com/apache/shardingsphere/pull/9306
Fixes #6480.
Changes proposed in this pull request:
- add grammar for truncate table
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #9306: feature: truncate table in oracle.
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9306:
URL: https://github.com/apache/shardingsphere/pull/9306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9306: feature: truncate table in oracle.
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9306:
URL: https://github.com/apache/shardingsphere/pull/9306#discussion_r569918316
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -394,3 +394,11 @@ enableDisableClause
enableDisableOthers
: (ENABLE | DISABLE) (TABLE LOCK | ALL TRIGGERS | CONTAINER_MAP | CONTAINERS_DEFAULT)
;
+
+materializedViewLogClause
+ : (PRESERVE | PURGE) MATERIALIZED VIEW LOG
+ ;
+
+storageClause
+ : (DROP (ALL)? | REUSE) STORAGE
+ ;
Review comment:
A new line is needed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #9306: feature: truncate table in oracle.
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #9306:
URL: https://github.com/apache/shardingsphere/pull/9306#discussion_r571350629
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -394,3 +394,11 @@ enableDisableClause
enableDisableOthers
: (ENABLE | DISABLE) (TABLE LOCK | ALL TRIGGERS | CONTAINER_MAP | CONTAINERS_DEFAULT)
;
+
+materializedViewLogClause
+ : (PRESERVE | PURGE) MATERIALIZED VIEW LOG
+ ;
+
+storageClause
+ : (DROP (ALL)? | REUSE) STORAGE
+ ;
Review comment:
I've fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org