You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/06/01 23:12:56 UTC
[GitHub] [helix] micahstubbs opened a new pull request, #2132: Upgrade helix-front to Angular 13.3
micahstubbs opened a new pull request, #2132:
URL: https://github.com/apache/helix/pull/2132
### Issue
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fix #2114
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR upgrades helix-front to Angular 13.3.
This PR completely contains earlier helix-front upgrade PRs #2113, #2111, #2104, #2094, #2092, #2087, #2083, and #2078. These previous Angular major-version PRs should be merged first.
### Tests
Let's test the upgrade from Angular 12.2 to Angular 13.3.
- [x] `yarn` successfully installs dependencies
- [x] `yarn type:check:watch` shows 0 TypeScript errors
- [x] `yarn lint` runs and passes `All files pass linting.`
- [x] `yarn build` works
- [x] `yarn start` works, with 0 errors in the browser console.
- [x] `yarn test` runs and passes.
`yarn start` works as expected, and recognizes our proxy config in `proxy.conf.json`. The Helix UI renders with 0 errors in the browser console.
<img width="726" alt="Screen Shot 2022-05-24 at 12 51 42 AM" src="https://user-images.githubusercontent.com/2119400/169982366-9906be2e-b053-497e-928a-cbc0a0b3ca86.png">
`yarn test` results
<img width="752" alt="Screen Shot 2022-05-24 at 1 08 23 AM" src="https://user-images.githubusercontent.com/2119400/169982414-5282afad-7d8a-432c-a4e2-4886d622354d.png">
### Documentation
- [x] In case of new functionality, my PR adds documentation in the following wiki page:
Not applicable since this PR does not contain new functionality, only tooling and dependency upgrades.
### Code Quality
- [x] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
Not applicable since this PR does not make any changes to the Java codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2132: Upgrade helix-front to Angular 13.3
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2132:
URL: https://github.com/apache/helix/pull/2132#issuecomment-1146362595
This PR is ready to be merged, approved by @somecodemonkey
## Final commit message: Upgrade helix-front to Angular 13.3 Fix 2114
Fix security vulnerabilities in helix-front dependencies.
Upgrade helix-front dependencies to improve contributor productivity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] somecodemonkey commented on pull request #2132: Upgrade helix-front to Angular 13.3
Posted by GitBox <gi...@apache.org>.
somecodemonkey commented on PR #2132:
URL: https://github.com/apache/helix/pull/2132#issuecomment-1146346331
🚢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2132: Upgrade helix-front to Angular 13.3
Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2132:
URL: https://github.com/apache/helix/pull/2132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2132: Upgrade helix-front to Angular 13.3
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2132:
URL: https://github.com/apache/helix/pull/2132#issuecomment-1146316921
@somecodemonkey this PR is ready for your review. Thanks for sharing your frontend expertise!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org