You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/11/08 19:09:48 UTC
[kudu-CR] Release notes for the Java client in 1.1
Hello Adar Dembo, John Russell,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5002
to review the following change.
Change subject: Release notes for the Java client in 1.1
......................................................................
Release notes for the Java client in 1.1
Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
---
M docs/release_notes.adoc
1 file changed, 23 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/5002/1
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[kudu-CR] Release notes for the Java client in 1.1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Release notes for the Java client in 1.1
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 50: troubleshooting
troubleshoot
PS1, Line 54: will not
"are not" (twice in this sentence)
PS1, Line 59: currently
: available
Replace with "existing"
PS1, Line 86: are not using the default
: timeouts anymore to wait for the requests to complete.
This part may be too much detail. Maybe it's enough to just say that before the sync API could throw two kinds of exceptions, now just one?
Line 91: * The Java client's handling of errors in `KuduSession` was modified so that subclasses of
Shouldn't this specifically refer to Flush() or Apply()? Not clear where these exceptions were being thrown from, or under what circumstances.
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Release notes for the Java client in 1.1
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Release notes for the Java client in 1.1
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 59: currently
: available
> You didn't drop "currently".
Missed the highlighting on the previous line.
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Release notes for the Java client in 1.1
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Release notes for the Java client in 1.1
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 50: troubleshooting
> troubleshoot
Done
PS1, Line 54: will not
> "are not" (twice in this sentence)
Done
PS1, Line 59: currently
: available
> Replace with "existing"
Done
PS1, Line 63: Use the revelant `ReplicaSelection`
: enum to the scanner's builder to change this behavior.
> Use... 'with' or 'on' or something.
Done
PS1, Line 86: are not using the default
: timeouts anymore to wait for the requests to complete.
> This part may be too much detail. Maybe it's enough to just say that before
Done
Line 91: * The Java client's handling of errors in `KuduSession` was modified so that subclasses of
> Shouldn't this specifically refer to Flush() or Apply()? Not clear where th
You can get those errors in apply, flush, and in the error collector. Basically, anywhere you can get a RowError, so that's why I didn't specify it.
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Release notes for the Java client in 1.1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Release notes for the Java client in 1.1
......................................................................
Patch Set 3: Code-Review+2
Leaving unmerged in case David wants to take another look.
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Release notes for the Java client in 1.1
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, John Russell, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5002
to look at the new patch set (#2).
Change subject: Release notes for the Java client in 1.1
......................................................................
Release notes for the Java client in 1.1
Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
---
M docs/release_notes.adoc
1 file changed, 22 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/5002/2
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Release notes for the Java client in 1.1
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Release notes for the Java client in 1.1
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 59: currently
: existing
> Done
You didn't drop "currently".
http://gerrit.cloudera.org:8080/#/c/5002/2/docs/release_notes.adoc
File docs/release_notes.adoc:
PS2, Line 63: revelant
relevant
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Release notes for the Java client in 1.1
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, John Russell, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5002
to look at the new patch set (#3).
Change subject: Release notes for the Java client in 1.1
......................................................................
Release notes for the Java client in 1.1
Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
---
M docs/release_notes.adoc
1 file changed, 22 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/5002/3
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Release notes for the Java client in 1.1
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Release notes for the Java client in 1.1
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Release notes for the Java client in 1.1
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Release notes for the Java client in 1.1
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 63: Use the revelant `ReplicaSelection`
: enum to the scanner's builder to change this behavior.
Use... 'with' or 'on' or something.
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Release notes for the Java client in 1.1
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: Release notes for the Java client in 1.1
......................................................................
Release notes for the Java client in 1.1
Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Reviewed-on: http://gerrit.cloudera.org:8080/5002
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Kudu Jenkins
---
M docs/release_notes.adoc
1 file changed, 20 insertions(+), 1 deletion(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Release notes for the Java client in 1.1
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Release notes for the Java client in 1.1
......................................................................
Patch Set 4:
Had to rebase and solve conflicts due to the other release notes that came in. David, you good with this?
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Release notes for the Java client in 1.1
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5002
to look at the new patch set (#4).
Change subject: Release notes for the Java client in 1.1
......................................................................
Release notes for the Java client in 1.1
Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
---
M docs/release_notes.adoc
1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/5002/4
--
To view, visit http://gerrit.cloudera.org:8080/5002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins