[GitHub] [netbeans] lkishalmi commented on pull request #5591: NETBEANS-1935: Add common shortcus to the empty editor view

["lkishalmi (via GitHub)" <gi...@apache.org>]

lkishalmi commented on PR #5591:
URL: https://github.com/apache/netbeans/pull/5591#issuecomment-1454028007

   Well, the dependencies are a bit wrong here.
   
   First core.windows shall not have a dependency on the editor (that is defined in the ide cluster)
   
   Better approach would be is to create an API interface in core windows like an `EditorPaneInfoProvider` or something which can return a Panel that the core.windows could render on the EditorPane when there is no open document.
   
   Use Lookup to get the instance for that provider in `EditorView`. Then create a separate module probably in the nb cluster to provide an implementation of the `EditorPaneInfoProvider`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists