[jira] [Resolved] (THRIFT-1144) Attributes from private to protected

["Jake Farrell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell resolved THRIFT-1144.
----------------------------------

    Resolution: Fixed
      Assignee: Jake Farrell

There are setters for the send/recv timeouts within TSocket, also since you have to call super in your constructor this would allow you to set a local variable if the connection was a persistent connection or not (similar to how TSocketPool is handling it). 

To make it easier I changed persist_ from private to protected in TSocket so overriding classes can reference socket connection type without needing a local variable. 

> Attributes from private to protected
> ------------------------------------
>
>                 Key: THRIFT-1144
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1144
>             Project: Thrift
>          Issue Type: Wish
>          Components: PHP - Library
>    Affects Versions: 0.7
>            Reporter: Torben Brodt
>            Assignee: Jake Farrell
>              Labels: inheritance, private, protected
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> I would like to change all attributes from private to protected.
> Cause of a bug in TSocket i wanted to inherit from this class to add a reconnect for persistent connection, but since all of the member variables were private i couldn't archieve that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira