[GitHub] [superset] villebro commented on a change in pull request #12857: refactor(color-schemes): refactor setting of color schemes

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #12857:
URL: https://github.com/apache/superset/pull/12857#discussion_r567657477



##########
File path: superset-frontend/src/setup/setupColors.ts
##########
@@ -16,36 +16,39 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import airbnb from '@superset-ui/core/esm/color/colorSchemes/categorical/airbnb';
-import categoricalD3 from '@superset-ui/core/esm/color/colorSchemes/categorical/d3';
-import echarts from '@superset-ui/core/esm/color/colorSchemes/categorical/echarts';
-import google from '@superset-ui/core/esm/color/colorSchemes/categorical/google';
-import lyft from '@superset-ui/core/esm/color/colorSchemes/categorical/lyft';
-import preset from '@superset-ui/core/esm/color/colorSchemes/categorical/preset';
-import sequentialCommon from '@superset-ui/core/esm/color/colorSchemes/sequential/common';
-import sequentialD3 from '@superset-ui/core/esm/color/colorSchemes/sequential/d3';
+import airbnb from '@superset-ui/core/lib/color/colorSchemes/categorical/airbnb';
+import categoricalD3 from '@superset-ui/core/lib/color/colorSchemes/categorical/d3';
+import echarts from '@superset-ui/core/lib/color/colorSchemes/categorical/echarts';
+import google from '@superset-ui/core/lib/color/colorSchemes/categorical/google';
+import lyft from '@superset-ui/core/lib/color/colorSchemes/categorical/lyft';
+import preset from '@superset-ui/core/lib/color/colorSchemes/categorical/preset';
+import sequentialCommon from '@superset-ui/core/lib/color/colorSchemes/sequential/common';
+import sequentialD3 from '@superset-ui/core/lib/color/colorSchemes/sequential/d3';
 import {
+  CategoricalScheme,
   getCategoricalSchemeRegistry,
   getSequentialSchemeRegistry,
+  SequentialScheme,
 } from '@superset-ui/core';
-import superset from '@superset-ui/core/esm/color/colorSchemes/categorical/superset';
+import superset from '@superset-ui/core/lib/color/colorSchemes/categorical/superset';
+import ColorScheme from '@superset-ui/core/lib/color/ColorScheme';
 
 export default function setupColors(
-  extraCategoricalColorSchemas,
-  extraSequentialColorSchemes,
+  extraCategoricalColorSchemas: ColorScheme[] = [],
+  extraSequentialColorSchemes: ColorScheme[] = [],

Review comment:
       Should this be
   ```suggestion
     extraCategoricalColorSchemas: CategoricalColorScheme[] = [],
     extraSequentialColorSchemes: SequentialColorScheme[] = [],
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org