[jira] Updated: (AMQ-1858) Integer overflow in default settings

["Earl Woodman (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/activemq/browse/AMQ-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Earl Woodman updated AMQ-1858:
------------------------------

    Attachment: amq_1858.patch

Attaching a patch which fixes this issue and adds a unit test to ensure its correctness in the future.

> Integer overflow in default settings
> ------------------------------------
>
>                 Key: AMQ-1858
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1858
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.1.0
>            Reporter: Simone Bordet
>         Attachments: amq_1858.patch
>
>
> From BrokerService, line 711-2:
> systemUsage.getTempUsage().setLimit(1024 * 1024 * 1024 * 100); // 10 Gb
> systemUsage.getStoreUsage().setLimit(1024 * 1024 * 1024 * 100); // 100 GB
> The expression 1024 * 1024 * 1024 * 100 overflows int, so the above lines actually correspond to setLimit(0).
> Easy fix is to make one of the multipliers a long, for example:
> 1024L * 1024 * 1024 * 100
> Other places may have the same problem, but I did not look for all places.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.