You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Chris Chabot <ch...@xs4all.nl> on 2008/05/07 23:12:02 UTC
Core.io patch for ContentType.FEED support in PHP
I see this patch is pending for the java implementation too:
--- features/core.io/io.js (revision 654160)
+++ features/core.io/io.js (working copy)
@@ -307,7 +307,10 @@
oauthService : oauthService || "",
oauthToken : oauthToken || "",
signOwner : signOwner || "true",
- signViewer : signViewer || "true"
+ signViewer : signViewer || "true",
+ contentType : params.CONTENT_TYPE || "TEXT",
+ numEntries : params.NUM_ENTRIES || "3",
+ getSummaries : (params.GET_SUMMARIES ? "true" : "false")
};
if (!respondWithPreload(paramData, params, callback,
processResponse)) {
The PHP implementation for ContentType.FEED support is done and
requires this for its functioning, anyone have any objections to me
going ahead and committing this?
-- Chris
Re: Core.io patch for ContentType.FEED support in PHP
Posted by Gary Helmling <gh...@gmail.com>.
Hi Kevin,
I just submitted a new patch that brings the Java implementation up to
data against the current trunk. All of the previously mentioned code
style issues (brace alignment, line length) should be fixed. If there
are any remaining code style or other issues, please let me know.
Thanks,
Gary
On Wed, May 7, 2008 at 5:22 PM, Kevin Brown <et...@google.com> wrote:
> Why don't you go ahead and commit just the javascript parts; I think there
> might still be some outstanding issues on the Java code.
>
>
>
> On Wed, May 7, 2008 at 2:12 PM, Chris Chabot <ch...@xs4all.nl> wrote:
>
> > I see this patch is pending for the java implementation too:
> >
> > --- features/core.io/io.js (revision 654160)
> > +++ features/core.io/io.js (working copy)
> > @@ -307,7 +307,10 @@
> > oauthService : oauthService || "",
> > oauthToken : oauthToken || "",
> > signOwner : signOwner || "true",
> > - signViewer : signViewer || "true"
> > + signViewer : signViewer || "true",
> > + contentType : params.CONTENT_TYPE || "TEXT",
> > + numEntries : params.NUM_ENTRIES || "3",
> > + getSummaries : (params.GET_SUMMARIES ? "true" : "false")
> > };
> >
> > if (!respondWithPreload(paramData, params, callback,
> > processResponse)) {
> >
> > The PHP implementation for ContentType.FEED support is done and requires
> > this for its functioning, anyone have any objections to me going ahead and
> > committing this?
> >
> > -- Chris
> >
>
Re: Core.io patch for ContentType.FEED support in PHP
Posted by Chris Chabot <ch...@xs4all.nl>.
Cool, will do
-- Chris
On May 7, 2008, at 11:22 PM, Kevin Brown wrote:
> Oh, and getSummaries can be !!params.GET_SUMMARIES
>
> On Wed, May 7, 2008 at 2:22 PM, Kevin Brown <et...@google.com> wrote:
>
>> Why don't you go ahead and commit just the javascript parts; I
>> think there
>> might still be some outstanding issues on the Java code.
>>
>>
>> On Wed, May 7, 2008 at 2:12 PM, Chris Chabot <ch...@xs4all.nl>
>> wrote:
>>
>>> I see this patch is pending for the java implementation too:
>>>
>>> --- features/core.io/io.js (revision 654160)
>>> +++ features/core.io/io.js (working copy)
>>> @@ -307,7 +307,10 @@
>>> oauthService : oauthService || "",
>>> oauthToken : oauthToken || "",
>>> signOwner : signOwner || "true",
>>> - signViewer : signViewer || "true"
>>> + signViewer : signViewer || "true",
>>> + contentType : params.CONTENT_TYPE || "TEXT",
>>> + numEntries : params.NUM_ENTRIES || "3",
>>> + getSummaries : (params.GET_SUMMARIES ? "true" : "false")
>>> };
>>>
>>> if (!respondWithPreload(paramData, params, callback,
>>> processResponse)) {
>>>
>>> The PHP implementation for ContentType.FEED support is done and
>>> requires
>>> this for its functioning, anyone have any objections to me going
>>> ahead and
>>> committing this?
>>>
>>> -- Chris
>>>
>>
>>
Re: Core.io patch for ContentType.FEED support in PHP
Posted by Kevin Brown <et...@google.com>.
Oh, and getSummaries can be !!params.GET_SUMMARIES
On Wed, May 7, 2008 at 2:22 PM, Kevin Brown <et...@google.com> wrote:
> Why don't you go ahead and commit just the javascript parts; I think there
> might still be some outstanding issues on the Java code.
>
>
> On Wed, May 7, 2008 at 2:12 PM, Chris Chabot <ch...@xs4all.nl> wrote:
>
> > I see this patch is pending for the java implementation too:
> >
> > --- features/core.io/io.js (revision 654160)
> > +++ features/core.io/io.js (working copy)
> > @@ -307,7 +307,10 @@
> > oauthService : oauthService || "",
> > oauthToken : oauthToken || "",
> > signOwner : signOwner || "true",
> > - signViewer : signViewer || "true"
> > + signViewer : signViewer || "true",
> > + contentType : params.CONTENT_TYPE || "TEXT",
> > + numEntries : params.NUM_ENTRIES || "3",
> > + getSummaries : (params.GET_SUMMARIES ? "true" : "false")
> > };
> >
> > if (!respondWithPreload(paramData, params, callback,
> > processResponse)) {
> >
> > The PHP implementation for ContentType.FEED support is done and requires
> > this for its functioning, anyone have any objections to me going ahead and
> > committing this?
> >
> > -- Chris
> >
>
>
Re: Core.io patch for ContentType.FEED support in PHP
Posted by Kevin Brown <et...@google.com>.
Why don't you go ahead and commit just the javascript parts; I think there
might still be some outstanding issues on the Java code.
On Wed, May 7, 2008 at 2:12 PM, Chris Chabot <ch...@xs4all.nl> wrote:
> I see this patch is pending for the java implementation too:
>
> --- features/core.io/io.js (revision 654160)
> +++ features/core.io/io.js (working copy)
> @@ -307,7 +307,10 @@
> oauthService : oauthService || "",
> oauthToken : oauthToken || "",
> signOwner : signOwner || "true",
> - signViewer : signViewer || "true"
> + signViewer : signViewer || "true",
> + contentType : params.CONTENT_TYPE || "TEXT",
> + numEntries : params.NUM_ENTRIES || "3",
> + getSummaries : (params.GET_SUMMARIES ? "true" : "false")
> };
>
> if (!respondWithPreload(paramData, params, callback,
> processResponse)) {
>
> The PHP implementation for ContentType.FEED support is done and requires
> this for its functioning, anyone have any objections to me going ahead and
> committing this?
>
> -- Chris
>