You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/06 14:24:40 UTC
[GitHub] [inlong-website] liangyepianzhou opened a new pull request, #509: [INLONG-508][DOC] explain the process of extending an MQ dataProxy
liangyepianzhou opened a new pull request, #509:
URL: https://github.com/apache/inlong-website/pull/509
### Prepare a Pull Request
- Fixes https://github.com/apache/inlong-website/issues/508
### Motivation & Modifications
This article is aimed at DataProxy developers, trying to explain as fully as possible the process of extending an MQ dataProxy, strive to eliminate developer confusion and make it easy for dataprxoy to extend new MQ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] healchow commented on a diff in pull request #509: [INLONG-508][DOC] Add doc on how to extend other MQs in DataProxy
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #509:
URL: https://github.com/apache/inlong-website/pull/509#discussion_r942600352
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/development/inlong_dataproxy_extend.md:
##########
@@ -0,0 +1,33 @@
+---
+title: DataProxy 扩展
+sidebar_position: 4
+---
+
+## 总览
+本文面向 DataProxy 开发人员, 尝试尽可能全面地阐述扩展一个 MQ DataProxy所经过的历程, 力求消除开发者的困惑，让DataProxy扩展新的MQ变得简单。
+## 扩展 DataProxy MQ
+扩展一个 新的MQ DataProxy 主要分为两个步骤：
+### 第一步：
+继承实现AbstractZoneClusterProducer类。这个类的主要功能是加载对应的MQ配置项来配置和初始化特定的MQ集群，建立对应的PulsarClient和ProducerBuilder。
+这个类的位置在：
+``` shell
+rg.apache.inlong.dataproxy.sink.mqzone
+```
+重写 start() 方法，根据对应的 MQ 配置创建对应的 MQ client 和 producerBuilder。
+然后重写 public boolean send(DispatchProfile event) 方法.
Review Comment:
1. 说明中的代码，可以用 “\`” 引起来，比如：`public boolean send(DispatchProfile event)` 方法；
2. 中文文档中的标点，建议用中文，比如`.` -> `。`。
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/development/inlong_dataproxy_extend.md:
##########
@@ -0,0 +1,33 @@
+---
+title: DataProxy 扩展
+sidebar_position: 4
+---
+
+## 总览
+本文面向 DataProxy 开发人员, 尝试尽可能全面地阐述扩展一个 MQ DataProxy所经过的历程, 力求消除开发者的困惑，让DataProxy扩展新的MQ变得简单。
+## 扩展 DataProxy MQ
Review Comment:
1. 请在每一级标题开始前加一个空行；
2. 英文单词与中文之间添加一个空格，如果英文单词前后是标点符号，则不需要加空格。
3. 中文文档中的标点，建议用中文，比如`,` -> `，`。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] dockerzhang commented on pull request #509: [INLONG-508][DOC] Add doc on how to extend other MQs in DataProxy
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #509:
URL: https://github.com/apache/inlong-website/pull/509#issuecomment-1357301219
duplicated with https://github.com/apache/inlong-website/pull/652, close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong-website] dockerzhang closed pull request #509: [INLONG-508][DOC] Add doc on how to extend other MQs in DataProxy
Posted by GitBox <gi...@apache.org>.
dockerzhang closed pull request #509: [INLONG-508][DOC] Add doc on how to extend other MQs in DataProxy
URL: https://github.com/apache/inlong-website/pull/509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org