You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/20 16:50:26 UTC

[GitHub] [arrow-datafusion] alamb opened a new issue, #3908: Better api for setting `ConfigOptions` from SessionContext

alamb opened a new issue, #3908:
URL: https://github.com/apache/arrow-datafusion/issues/3908

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   Related to #3887 
   
   
   I want to set configuration options given a session context. Right now I need to do it like 🤮 
   
   ```rust
           let session_ctx = SessionContext::new();
   
           {
               // lock scope
               let state = session_ctx.state.write();
               let mut config_options = state.config.config_options.write();
               config_options.set_bool(OPT_PARQUET_PUSHDOWN_FILTERS, true);
               config_options.set_bool(OPT_PARQUET_REORDER_FILTERS, true);
           }
   ```
   
   
   **Describe the solution you'd like**
   
   I would like an API like this:
   ```rust
           let session_ctx = SessionContext::new()
             .with_bool(OPT_PARQUET_PUSHDOWN_FILTERS, true)
             .with_bool(OPT_PARQUET_REORDER_FILTERS, true);
   ```
   
   As well as
   ```rust
           let session_ctx = SessionContext::new();
           session_ctx.set_bool(OPT_PARQUET_PUSHDOWN_FILTERS, true);
           session_ctx.set_bool(OPT_PARQUET_REORDER_FILTERS, true);
   ```                                                                                      )
   
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #3908: Better api for setting `ConfigOptions` from SessionContext

Posted by GitBox <gi...@apache.org>.
alamb closed issue #3908: Better api for setting `ConfigOptions` from SessionContext
URL: https://github.com/apache/arrow-datafusion/issues/3908


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] comphead commented on issue #3908: Better api for setting `ConfigOptions` from SessionContext

Posted by GitBox <gi...@apache.org>.
comphead commented on issue #3908:
URL: https://github.com/apache/arrow-datafusion/issues/3908#issuecomment-1285899649

   @alamb I'm wondering if you ok with current working alternative
   
   `
       let ctx = SessionContext::with_config(SessionConfig::new().set_bool("key", true).set_bool("key2", false));
   `
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #3908: Better api for setting `ConfigOptions` from SessionContext

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3908:
URL: https://github.com/apache/arrow-datafusion/issues/3908#issuecomment-1338084687

   Let's discuss this in the larger context of https://github.com/apache/arrow-datafusion/issues/4349 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #3908: Better api for setting `ConfigOptions` from SessionContext

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3908:
URL: https://github.com/apache/arrow-datafusion/issues/3908#issuecomment-1286003117

   @comphead it is probably OK. 
   
   I don't plan to work on the ConfigOptions any more once I consolidate the parquet options. I guess I'll see if others have some ideas on how to make the API nicer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org