[GitHub] [druid] clintropolis edited a comment on issue #9507: optionally disable all of hardcoded zookeeper use

[GitBox <gi...@apache.org>]

clintropolis edited a comment on issue #9507: optionally disable all of hardcoded zookeeper use
URL: https://github.com/apache/druid/pull/9507#issuecomment-603005260
 
 
   Some thoughts as I've been reviewing this (sorry I haven't finished yet): 
   
   Do you view this as an interim configuration, to allow your work to proceed on an alternative discovery mechanism, until we can decouple zookeeper specific code from all of the places that need to check this setting? or is the plan to leave it like this? So far I find it kind of ugly to have a setting like this due to all of the if/else branches it causes, but maybe there is some obvious reason I haven't got to yet on why we aren't adding some sort of `druid.discovery.type=zk|none` instead of this enable/disable setting. I know some of the current HTTP modes are sort of leaky in terms of still doing zk stuff to support rolling update situations to transition settings, i would be in favor of breaking the current versions that support that, and adding some sort of composite or special mode to run both versions just for transition scenarios if that is the main driver to have the setting be this way.
   
   I'll keep reviewing, and try to finish up later tonight.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org