You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/26 21:40:33 UTC
[GitHub] [helix] kaisun2000 opened a new issue #1418: Fix TestSemiAutoRebalance.beforeClass
kaisun2000 opened a new issue #1418:
URL: https://github.com/apache/helix/issues/1418
LOG 1717
>2020-09-26T07:40:51.0177511Z [ERROR] beforeClass(org.apache.helix.integration.rebalancer.TestSemiAutoRebalance) Time elapsed: 6.504 s <<< FAILURE!
2020-09-26T07:40:51.0179493Z java.lang.AssertionError: expected:<1> but was:<0>
2020-09-26T07:40:51.0181738Z at org.apache.helix.integration.rebalancer.TestSemiAutoRebalance.beforeClass(TestSemiAutoRebalance.java:120)
2020-09-26T07:40:51.0183490Z
2020-09-26T07:40:51.4359939Z [ERROR] Failures:
2020-09-26T07:40:51.4361628Z [ERROR] TestSemiAutoRebalance.beforeClass:120 expected:<1> but was:<0>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1418: Fix TestSemiAutoRebalance.beforeClass
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1418:
URL: https://github.com/apache/helix/issues/1418#issuecomment-699551282
code
```
// start controller
String controllerName = CONTROLLER_PREFIX + "_0";
_controller = new ClusterControllerManager(ZK_ADDR, CLUSTER_NAME, controllerName);
_controller.syncStart();
Thread.sleep(1000);
// verify ideal state and external view
IdealState idealState = _accessor.getProperty(_keyBuilder.idealStates(DB_NAME));
Assert.assertNotNull(idealState);
Assert.assertEquals(idealState.getNumPartitions(), PARTITION_NUMBER);
for (String partition : idealState.getPartitionSet()) {
List<String> preferenceList = idealState.getPreferenceList(partition);
Assert.assertNotNull(preferenceList);
Assert.assertEquals(preferenceList.size(), REPLICA_NUMBER);
}
ExternalView externalView = _accessor.getProperty(_keyBuilder.externalView(DB_NAME));
Assert.assertNotNull(externalView);
Assert.assertEquals(externalView.getPartitionSet().size(), PARTITION_NUMBER);
for (String partition : externalView.getPartitionSet()) {
Map<String, String> stateMap = externalView.getStateMap(partition);
Assert.assertEquals(stateMap.size(), REPLICA_NUMBER);
int masters = 0;
for (String state : stateMap.values()) {
if (state.equals(MasterSlaveSMD.States.MASTER.name())) {
++masters;
}
}
Assert.assertEquals(masters, 1);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 edited a comment on issue #1418: Fix TestSemiAutoRebalance.beforeClass
Posted by GitBox <gi...@apache.org>.
kaisun2000 edited a comment on issue #1418:
URL: https://github.com/apache/helix/issues/1418#issuecomment-699551358
Root cause: too old way to wait for cluster converge. 1000ms does not guarantee it.
use bestPossibleExternalViewVerifier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on issue #1418: Fix TestSemiAutoRebalance.beforeClass
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #1418:
URL: https://github.com/apache/helix/issues/1418#issuecomment-849104881
Close test unstable tickets since we have an automatic tracking mechanism https://github.com/apache/helix/pull/1757 now for tracking the most recent test issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang closed issue #1418: Fix TestSemiAutoRebalance.beforeClass
Posted by GitBox <gi...@apache.org>.
jiajunwang closed issue #1418:
URL: https://github.com/apache/helix/issues/1418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1418: Fix TestSemiAutoRebalance.beforeClass
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1418:
URL: https://github.com/apache/helix/issues/1418#issuecomment-699551358
Root cause: too old way to wait for cluster converge. 1000 does not guarantee it.
use bestPossibleExternalViewVerifier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org