[GitHub] [geode] upthewaterspout commented on a change in pull request #6123: GEODE-9019: Fixed synchronization blocks missed in previous commit

[GitBox <gi...@apache.org>]

upthewaterspout commented on a change in pull request #6123:
URL: https://github.com/apache/geode/pull/6123#discussion_r596261087



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/data/RedisString.java
##########
@@ -615,7 +615,7 @@ public int setbit(
    */
 
   @Override
-  public void toData(DataOutput out, SerializationContext context) throws IOException {
+  public synchronized void toData(DataOutput out, SerializationContext context) throws IOException {

Review comment:
       Ok. I will approve this PR with the understanding that there will be another fix to synchronize the rest of the memthods in RedisString.
   
   When I was talking about tests, I meant tests that show that we actually need synchronization. Like a test that shows data corruption if we don't have synchronization. I'm not sure there is much value in programatically testing that the method has a synchronization modifier.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org