You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacopo Cappellato (JIRA)" <ji...@apache.org> on 2015/04/21 11:12:58 UTC

[jira] [Commented] (OFBIZ-6270) base/json/JSON has been removed, with no deprecation window

    [ https://issues.apache.org/jira/browse/OFBIZ-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504651#comment-14504651 ] 

Jacopo Cappellato commented on OFBIZ-6270:
------------------------------------------

The "proper approach" you mention is definitely a good way to go but it is not something that we are enforcing and/or implementing consistently in OFBiz.
We could say that at the moment the OFBiz APIs and in general the framework code is fluid and could change even if this can cause backward incompatibilities.
However the project/community puts some effort in trying to not cause backward incompatibilities between releases in the same release branch; on the other hand it is currently accepted that from a release branch to the next there could be incompatibilities even without the implementation of a deprecation pattern.
It will be easier to implement a formal deprecation pattern, as you recommend, when we will have a separate release for the framework but for now we should not bring back code just to implement/enforce it.


> base/json/JSON has been removed, with no deprecation window
> -----------------------------------------------------------
>
>                 Key: OFBIZ-6270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Trunk, 12.04.04
>            Reporter: Adam Heath
>            Assignee: Adam Heath
>            Priority: Critical
>
> The antlr-based json parser(at org.ofbiz.base.json.JSON.cc) was removed last October(2014-10-27).  However, no backwards-compatible class was left in place, with a proper @Deprecation tag applied.
> The proper approach should have been to leave the class in place, adding @Deprecation, and leaving the json-lib.jar in place.  Then, after one successful release, removing the actual code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)