You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/21 07:45:06 UTC
[GitHub] [pulsar] poorbarcode opened a new pull request, #19014: [fix] [doc] Fix outdated doc of rate limiter
poorbarcode opened a new pull request, #19014:
URL: https://github.com/apache/pulsar/pull/19014
### Motivation
After PR #8611, the acquiring permits can be larger than configured msg-rate if used by subscribing. But doc was not updated in time.
### Modifications
fix the outdated doc
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
- no needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter
Posted by github-actions.
github-actions[bot] commented on PR #19014:
URL: https://github.com/apache/pulsar/pull/19014#issuecomment-1405924090
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19014:
URL: https://github.com/apache/pulsar/pull/19014#issuecomment-1502651244
## [Codecov](https://codecov.io/gh/apache/pulsar/pull/19014?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19014](https://codecov.io/gh/apache/pulsar/pull/19014?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (55a07c0) into [master](https://codecov.io/gh/apache/pulsar/commit/08591d9da87579705f8ee950d745718a92bdd15e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08591d9) will **decrease** coverage by `16.81%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/19014?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19014 +/- ##
=============================================
- Coverage 49.85% 33.04% -16.81%
- Complexity 8658 12192 +3534
=============================================
Files 500 1547 +1047
Lines 54930 114431 +59501
Branches 5867 12400 +6533
=============================================
+ Hits 27386 37817 +10431
- Misses 24464 71688 +47224
- Partials 3080 4926 +1846
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `33.04% <ø> (-16.81%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19014?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...broker/service/persistent/DispatchRateLimiter.java](https://codecov.io/gh/apache/pulsar/pull/19014?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvRGlzcGF0Y2hSYXRlTGltaXRlci5qYXZh) | `79.85% <ø> (+4.47%)` | :arrow_up: |
... and [1413 files with indirect coverage changes](https://codecov.io/gh/apache/pulsar/pull/19014/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode closed pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode closed pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter
URL: https://github.com/apache/pulsar/pull/19014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on code in PR #19014:
URL: https://github.com/apache/pulsar/pull/19014#discussion_r1056197745
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/DispatchRateLimiter.java:
##########
@@ -99,10 +99,10 @@ public long getAvailableDispatchRateLimitOnByte() {
*/
public boolean tryDispatchPermit(long msgPermits, long bytePermits) {
boolean acquiredMsgPermit = msgPermits <= 0 || dispatchRateLimiterOnMessage == null
- // acquiring permits must be < configured msg-rate;
+ // In dispatch mode, acquiring permits can be larger than configured msg-rate.
Review Comment:
dispatch mode represents what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on code in PR #19014:
URL: https://github.com/apache/pulsar/pull/19014#discussion_r1056197745
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/DispatchRateLimiter.java:
##########
@@ -99,10 +99,10 @@ public long getAvailableDispatchRateLimitOnByte() {
*/
public boolean tryDispatchPermit(long msgPermits, long bytePermits) {
boolean acquiredMsgPermit = msgPermits <= 0 || dispatchRateLimiterOnMessage == null
- // acquiring permits must be < configured msg-rate;
+ // In dispatch mode, acquiring permits can be larger than configured msg-rate.
Review Comment:
dispatch mode represents what? it is singleDispatcher and multiDispatcher, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on code in PR #19014:
URL: https://github.com/apache/pulsar/pull/19014#discussion_r1057408809
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/DispatchRateLimiter.java:
##########
@@ -99,10 +99,10 @@ public long getAvailableDispatchRateLimitOnByte() {
*/
public boolean tryDispatchPermit(long msgPermits, long bytePermits) {
boolean acquiredMsgPermit = msgPermits <= 0 || dispatchRateLimiterOnMessage == null
- // acquiring permits must be < configured msg-rate;
+ // In dispatch mode, acquiring permits can be larger than configured msg-rate.
Review Comment:
> dispatch mode represents what? it is singleDispatcher and multiDispatcher, right?
Yes, I have removed these two java-doc because it is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie merged pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter
Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie merged PR #19014:
URL: https://github.com/apache/pulsar/pull/19014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on code in PR #19014:
URL: https://github.com/apache/pulsar/pull/19014#discussion_r1057408809
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/DispatchRateLimiter.java:
##########
@@ -99,10 +99,10 @@ public long getAvailableDispatchRateLimitOnByte() {
*/
public boolean tryDispatchPermit(long msgPermits, long bytePermits) {
boolean acquiredMsgPermit = msgPermits <= 0 || dispatchRateLimiterOnMessage == null
- // acquiring permits must be < configured msg-rate;
+ // In dispatch mode, acquiring permits can be larger than configured msg-rate.
Review Comment:
> dispatch mode represents what? it is singleDispatcher and multiDispatcher, right?
Yes, I have removed these two java-doc because it is outedated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org