You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/02 16:37:14 UTC
Review Request 56229: Workflow name mandatory for save in Coordinator
and Bundle
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56229/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19852
https://issues.apache.org/jira/browse/AMBARI-19852
Repository: ambari
Description
-------
Workflow name mandatory for save also in Coordinator and Bundle. This way we can show the workflow name in the recent workflows list.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 7b24d34
contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 57dbeb0
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 4618ab6
Diff: https://reviews.apache.org/r/56229/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 56229: Workflow name mandatory for save in
Coordinator and Bundle
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56229/#review163998
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Feb. 2, 2017, 4:37 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56229/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 4:37 p.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19852
> https://issues.apache.org/jira/browse/AMBARI-19852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Workflow name mandatory for save also in Coordinator and Bundle. This way we can show the workflow name in the recent workflows list.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 7b24d34
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 57dbeb0
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 4618ab6
>
> Diff: https://reviews.apache.org/r/56229/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56229: Workflow name mandatory for save in
Coordinator and Bundle
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56229/#review163994
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 2, 2017, 4:37 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56229/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 4:37 p.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19852
> https://issues.apache.org/jira/browse/AMBARI-19852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Workflow name mandatory for save also in Coordinator and Bundle. This way we can show the workflow name in the recent workflows list.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 7b24d34
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 57dbeb0
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 4618ab6
>
> Diff: https://reviews.apache.org/r/56229/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>