You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2018/05/02 12:25:16 UTC
[Bug 7578] New: PgSQL table txrep field name invalid
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
Bug ID: 7578
Summary: PgSQL table txrep field name invalid
Product: Spamassassin
Version: unspecified
Hardware: PC
OS: Windows NT
Status: NEW
Severity: normal
Priority: P2
Component: Plugins
Assignee: dev@spamassassin.apache.org
Reporter: gianluca.giacometti@unipd.it
Target Milestone: Undefined
count is not a proper field name for a postgresql table
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #5602|0 |1
is obsolete| |
--- Comment #10 from Giovanni Bechis <gi...@paclan.it> ---
Created attachment 5603
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5603&action=edit
TxRep count field rename
For consinstency I renamed the count field in DBBasedAddrList.pm as well,
what is the correct way for people using TxRep without a sql database to move
from old format to the new one ?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
--- Comment #9 from Kevin A. McGrail <km...@apache.org> ---
I see it now. The Diff got rejected on my checkout. Sorry
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@apache.org
--- Comment #1 from Kevin A. McGrail <km...@apache.org> ---
Can you be more specific when you are seeing this issue? Are you saying that
the txrep_pg.sql doesn't work?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
--- Comment #8 from Giovanni Bechis <gi...@paclan.it> ---
The UPGRADE stuff is in the diff, are you referring to another file ?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |giovanni@paclan.it
--- Comment #2 from Giovanni Bechis <gi...@paclan.it> ---
I have no problems with MariaDB database and
I have not tested with Postgres but "count" is a reserved word at least in
Postgres 9.6:
https://www.postgresql.org/docs/9.6/static/sql-keywords-appendix.html
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
--- Comment #4 from Giovanni Bechis <gi...@paclan.it> ---
Older version are not affected, I do not know which is the first Postgresql
version that triggers this bug.
Both awl and txrep are affected because they have similar databases.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #13 from Giovanni Bechis <gi...@paclan.it> ---
Fixed with commit r1844306 in 3.4 and trunk trees.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
Gianluca Giacometti <gi...@unipd.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gianluca.giacometti@unipd.i
| |t
Hardware|PC |Other
OS|Windows NT |Linux
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.0.0 |3.4.3
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
--- Comment #12 from Giovanni Bechis <gi...@paclan.it> ---
Looking at "db_dump -p" output it seems that no operation is needed on bdb
database if we change a field name in DBBasedAddrList.pm code.
----------------------------------------------------------
VERSION=3
format=print
type=hash
h_nelem=122
db_pagesize=4096
HEADER=END
185.153.110.130|ip=46.30|totscore
1.48
DATA=END
----------------------------------------------------------
Can anybody confirm ?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |4.0.0
Severity|normal |critical
--- Comment #3 from Kevin A. McGrail <km...@apache.org> ---
Interesting. I'll assume it wasn't in an older version? Does this only affect
txrep??
I think this will require changing txrep's database format. Target for
3.4.3/4.0.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
--- Comment #7 from Kevin A. McGrail <km...@apache.org> ---
We'll need an upgrade file addition for this as well.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
--- Comment #11 from Kevin A. McGrail <km...@apache.org> ---
(In reply to Giovanni Bechis from comment #10)
> Created attachment 5603 [details]
> TxRep count field rename
>
> For consinstency I renamed the count field in DBBasedAddrList.pm as well,
> what is the correct way for people using TxRep without a sql database to
> move
> from old format to the new one ?
I dn't believe there is a process documented. Can you take a pass at it?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
--- Comment #6 from Giovanni Bechis <gi...@paclan.it> ---
Created attachment 5602
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5602&action=edit
rename count field to msgcount
Database field "count" renamed to "msgcount", tested with MySQL and TxRep ATM.
Tests with Postgresql and/or Awl plugin will be welcome.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7578] PgSQL table txrep field name invalid
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7578
--- Comment #5 from Gianluca Giacometti <gi...@unipd.it> ---
(In reply to Kevin A. McGrail from comment #1)
> Can you be more specific when you are seeing this issue? Are you saying
> that the txrep_pg.sql doesn't work?
Yes it doesn't work because it considers count as a a reserved word for count.
PostgreSQL 10 in Ubuntu 18.04 LTS
--
You are receiving this mail because:
You are the assignee for the bug.