You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/27 17:17:08 UTC

[jclouds-labs-aws] Revert requiring guava 17 (#62)

see https://issues.apache.org/jira/browse/JCLOUDS-534 for discussion
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds-labs-aws adrian.less-guava-incompatibility

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-aws/pull/62

-- Commit Summary --

  * JCLOUDS-534 Avoid runtime incompatibility introduced by Guava&#39;s closeQuietly.

-- File Changes --

    M glacier/src/main/java/org/jclouds/glacier/util/AWSRequestSignerV4.java (4)
    M glacier/src/main/java/org/jclouds/glacier/util/TreeHash.java (4)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-aws/pull/62.patch
https://github.com/jclouds/jclouds-labs-aws/pull/62.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/62

Re: [jclouds-labs-aws] Revert requiring guava 17 (#62)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-aws-pull-requests #129](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/129/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/62#issuecomment-60624006

Re: [jclouds-labs-aws] Revert requiring guava 17 (#62)

Posted by Adrian Cole <no...@github.com>.
@demobox nag!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/62#issuecomment-61026772

Re: [jclouds-labs-aws] Revert requiring guava 17 (#62)

Posted by Adrian Cole <no...@github.com>.
Closed #62.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/62#event-185700468

Re: [jclouds-labs-aws] Revert requiring guava 17 (#62)

Posted by Andrew Phillips <no...@github.com>.
+1 - looks good to me.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/62#issuecomment-61037174

Re: [jclouds-labs-aws] Revert requiring guava 17 (#62)

Posted by Adrian Cole <no...@github.com>.
cherry-picked into master, 1.8.x

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/62#issuecomment-61034404

Re: [jclouds-labs-aws] Revert requiring guava 17 (#62)

Posted by Adrian Cole <no...@github.com>.
merging as build is broke

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/62#issuecomment-61034113

Re: [jclouds-labs-aws] Revert requiring guava 17 (#62)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-aws #1533](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/1533/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/62#issuecomment-60625277