You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2018/01/26 09:27:07 UTC

[GitHub] flink pull request #5370: [hotfix] [table] Fix IndexOutOfBoundsException in ...

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/5370

    [hotfix] [table] Fix IndexOutOfBoundsException in DataStreamSortRule.

    ## What is the purpose of the change
    
    Fixes an `IndexOutOfBoundsException` in `DataStreamSortRule` if a plan contains a sort operator without sorting fields (just LIMIT / FETCH).
    
    ## Brief change log
    
    * Check number of sort fields before checking type of first field.
    
    ## Verifying this change
    
    Not covered by tests. `ORDER BY` without sorting fields are not supported cannot be translated. This change just prevents an exception but does not enable the feature.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **n/a**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableFixSortIOOBE

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5370
    
----
commit c4b7f5bbdcd8dbfa8cd433316326b682ddb93f08
Author: Fabian Hueske <fh...@...>
Date:   2018-01-26T09:19:17Z

    [hotfix] [table] Fix IndexOOBE in DataStreamSortRule.

----


---

[GitHub] flink issue #5370: [hotfix] [table] Fix IndexOutOfBoundsException in DataStr...

Posted by twalthr <gi...@git.apache.org>.

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/5370
  
    Thanks for the PR @fhueske. I will merge this.


---

[GitHub] flink pull request #5370: [hotfix] [table] Fix IndexOutOfBoundsException in ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5370


---