You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/11 08:33:44 UTC

[GitHub] [flink] atris opened a new pull request #14368: FLINK-18778: Support the SupportsProjectionPushDown interface for Loo…

atris opened a new pull request #14368:
URL: https://github.com/apache/flink/pull/14368


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14368: FLINK-18778: Support the SupportsProjectionPushDown interface for Loo…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14368:
URL: https://github.com/apache/flink/pull/14368#issuecomment-743054994

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 6f9516eb5a7b7e5962df822168737fc85db1c3f9 (Fri Dec 11 08:36:20 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on pull request #14368: FLINK-18778: Support the SupportsProjectionPushDown interface for Loo…

Posted by GitBox <gi...@apache.org>.

wuchong commented on pull request #14368:
URL: https://github.com/apache/flink/pull/14368#issuecomment-743063287


   Hi @atris , this task doesn't mean to make `LookupTableSource` extends `SupportsProjectionPushDown`. But to make `LookupTableSource` can have the ability of  `SupportsProjectionPushDown`. Currently, only `ScanTableSource` supports `SupportsProjectionPushDown`. We need to update the planner and optimizer to support this. 
   
   I will close this PR for now. 
   
   Besides, @hailong has taken this issue. I'm not sure whether he has been starting working on this. Would be better to coordinate the work in the JIRA issue. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14368: FLINK-18778: Support the SupportsProjectionPushDown interface for Loo…

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14368:
URL: https://github.com/apache/flink/pull/14368#issuecomment-743060899


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6f9516eb5a7b7e5962df822168737fc85db1c3f9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6f9516eb5a7b7e5962df822168737fc85db1c3f9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6f9516eb5a7b7e5962df822168737fc85db1c3f9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong closed pull request #14368: FLINK-18778: Support the SupportsProjectionPushDown interface for Loo…

Posted by GitBox <gi...@apache.org>.

wuchong closed pull request #14368:
URL: https://github.com/apache/flink/pull/14368


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org