You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Tellier Benoit (JIRA)" <se...@james.apache.org> on 2018/04/27 07:29:00 UTC
[jira] [Updated] (JAMES-2385) $Draft checks should rely on JMAP
flags view
[ https://issues.apache.org/jira/browse/JAMES-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tellier Benoit updated JAMES-2385:
----------------------------------
Description:
When moving a message to outbox (aka sending), SetMessageUpdate performs a check: "Is the message marked with $Draft"?
Due to possible multiple mailbox contexts, we have to combine the flags together to answer that question. Nowadays, SetMessageUpdate perform custom logic, not related to other JMAP views and components.
This makes code fragile: If keyword combination is changed elsewhere (eg GetMessages) then I might not be able to move some Draft messages to Outbox (because I might forgot to change the SetMessageUpdate).
We need to remove that coupling.
Keyword reduction in SetMessageUpdate needs to rely on *KeywordsCombiner*
was:
When moving a message to outbox (akka sending), SetMessageUpdate performs a check: "Is the message marked with $Draft"?
Due to possible multiple mailbox contexts, we have to combine the flags together to answer that question. Nowadays, SetMessageUpdate perform custom logic, not related to other JMAP views and components.
This makes code fragile: If keyword combination is changed elsewhere (eg GetMessages) then I might not be able to move some Draft messages to Outbox (because I might forgot to change the SetMessageUpdate).
We need to remove that coupling.
Keyword reduction in SetMessageUpdate needs to rely on *KeywordsCombiner*
> $Draft checks should rely on JMAP flags view
> --------------------------------------------
>
> Key: JAMES-2385
> URL: https://issues.apache.org/jira/browse/JAMES-2385
> Project: James Server
> Issue Type: Improvement
> Components: JMAP
> Reporter: Tellier Benoit
> Assignee: Antoine Duprat
> Priority: Major
>
> When moving a message to outbox (aka sending), SetMessageUpdate performs a check: "Is the message marked with $Draft"?
> Due to possible multiple mailbox contexts, we have to combine the flags together to answer that question. Nowadays, SetMessageUpdate perform custom logic, not related to other JMAP views and components.
> This makes code fragile: If keyword combination is changed elsewhere (eg GetMessages) then I might not be able to move some Draft messages to Outbox (because I might forgot to change the SetMessageUpdate).
> We need to remove that coupling.
> Keyword reduction in SetMessageUpdate needs to rely on *KeywordsCombiner*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org