You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Mingliang Liu (JIRA)" <ji...@apache.org> on 2018/08/17 23:38:00 UTC

[jira] [Created] (HBASE-21071) HBaseTestingUtility::startMiniCluster() to use builder pattern

Mingliang Liu created HBASE-21071:
-------------------------------------

             Summary: HBaseTestingUtility::startMiniCluster() to use builder pattern
                 Key: HBASE-21071
                 URL: https://issues.apache.org/jira/browse/HBASE-21071
             Project: HBase
          Issue Type: Bug
          Components: test
    Affects Versions: 3.0.0
            Reporter: Mingliang Liu
            Assignee: Mingliang Liu


Currently there are 13 {{startMiniCluster()}} methods to set up a mini cluster. I'm not surprised if we have a few more in future. It's good to support different combination of optional parameters. We have to pick up one of them carefully while still wondering the default values of other parameters; if we add a new option, we may bring more new methods.

One solution is to use builder pattern: create a class {{MiniClusterOptions}} along with a static class {{MiniClusterOptionsBuilder}}, create a new method  {{startMiniCluster(MiniClusterOptions)}}. In {{master}} we delete the old 13 methods while in branch-2, we deprecate the old 13 methods.

Thoughts?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)