You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "nyang404 (via GitHub)" <gi...@apache.org> on 2026/09/01 12:43:44 UTC
[PR] i18n(ko): add missing translations(Sep 1) [airflow]
nyang404 opened a new pull request, #72372:
URL: https://github.com/apache/airflow/pull/72372
Added missing Korean translations in the 'partition' section of 'ko/components.json'.
- partitionRange: 파티션 범위
- partitionsAffected_one: 1개의 파티션이 백필됩니다:
- partitionsAffected_other: {{count}}개의 파티션이 백필됩니다:
- partitionsNone: 선택한 범위에 일치하는 파티션이 없습니다.
Verified by `breeze ui check-translation-completeness --language ko`
### Before
<img width="1180" height="560" alt="airflow_translation_before-components" src="https://github.com/user-attachments/assets/f1f09e56-1006-4600-a529-205cdeef52c6" />
### After
<img width="1159" height="564" alt="airflow_translation_after-components" src="https://github.com/user-attachments/assets/d448b0a2-d2e6-4955-b965-72450fd6f8b5" />
cc: @onestn @noeunkim
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): add missing translations(Sep 1) [airflow]
Posted by "nyang404 (via GitHub)" <gi...@apache.org>.
nyang404 commented on code in PR #72372:
URL: https://github.com/apache/airflow/pull/72372#discussion_r3912982687
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/components.json:
##########
Review Comment:
Hi, would it be okay if I make one more pass and add the remaining missing translations to this PR as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): add missing translations(Sep 1) [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #72372:
URL: https://github.com/apache/airflow/pull/72372#issuecomment-5571039486
The CI failure doesn't seem to be related to your changes.
Since it's already been resolved on main, I'll rebase the branch.
Let's wait for the CI checks to turn green :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): add missing translations(Sep 1) [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 merged PR #72372:
URL: https://github.com/apache/airflow/pull/72372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): add missing translations(Sep 1) [airflow]
Posted by "yuseok89 (via GitHub)" <gi...@apache.org>.
yuseok89 commented on PR #72372:
URL: https://github.com/apache/airflow/pull/72372#issuecomment-5571660772
LGTM as well, and CI is green now.
Thanks for covering the remaining keys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): add missing translations(Sep 1) [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #72372:
URL: https://github.com/apache/airflow/pull/72372#issuecomment-5494125098
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): add missing translations(Sep 1) [airflow]
Posted by "yuseok89 (via GitHub)" <gi...@apache.org>.
yuseok89 commented on code in PR #72372:
URL: https://github.com/apache/airflow/pull/72372#discussion_r3909303456
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/components.json:
##########
Review Comment:
Thanks for the fix!
As of current main, ko has 15 more missing keys, would you like to cover them in this PR too, or is it okay if I pick them up in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): add missing translations(Sep 1) [airflow]
Posted by "nyang404 (via GitHub)" <gi...@apache.org>.
nyang404 commented on code in PR #72372:
URL: https://github.com/apache/airflow/pull/72372#discussion_r3930018201
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/components.json:
##########
Review Comment:
Apologies for not mentioning this sooner. I've pushed a commit that includes the additional translations as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): add missing translations(Sep 1) [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #72372:
URL: https://github.com/apache/airflow/pull/72372#issuecomment-5571706770
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org