You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/20 18:02:40 UTC

[GitHub] [cloudstack] wido commented on a change in pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages

wido commented on a change in pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#discussion_r561166522



##########
File path: debian/rules
##########
@@ -93,6 +93,12 @@ override_dh_auto_install:
 	install -m0644 packaging/systemd/$(PACKAGE)-management.service debian/$(PACKAGE)-management/lib/systemd/system/$(PACKAGE)-management.service
 	install -m0644 packaging/systemd/$(PACKAGE)-management.default $(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-management
 
+	# cloudstack-ui
+	mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+	cd ui && npm install && npm run build && cd ..

Review comment:
       This assumes that npn is available on the system. However, that's not a guarantee.
   
   The .deb (and .rpm) should have a build depends on 'npm'




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org