[GitHub] [helix] narendly commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection

[GitBox <gi...@apache.org>]

narendly commented on issue #727: Add MetadataStoreRoutingDataWriter with DistributedLeaderElection
URL: https://github.com/apache/helix/pull/727#issuecomment-584308561
 
 
   > A generic comment on all writer logics: some deletion operations can lead to a data state that is deemed "invalid" by `ZkRoutingDataReader`. For example, removing the last realmAddress, or removing the last sharding key for a realmAddress.
   > Questions:
   > 
   > 1. Do we allow that to happen?
   > 2. If we don't allow that to happen, should the logic for checking these situations be a part of this PR, or a part of the validation logic PR?
   
   Could you include some specific examples? We could do either, but since other changes might be dependent on this diff, we could create an issue with your specific TODOs so that we could include that change in other PRs. @NealSun96 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org