You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/23 13:38:28 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2591: fs: Remove the softlink check from unlink

xiaoxiang781216 commented on a change in pull request #2591:
URL: https://github.com/apache/incubator-nuttx/pull/2591#discussion_r547962775



##########
File path: fs/vfs/fs_unlink.c
##########
@@ -114,13 +114,7 @@ int unlink(FAR const char *pathname)
    * or a soft link, then rm should remove the node.
    */
 
-#ifdef CONFIG_PSEUDOFS_SOFTLINKS
-  /* A soft link is the only "specal" file that we can remove via unlink(). */
-
-  if (!INODE_IS_SPECIAL(inode) || INODE_IS_SOFTLINK(inode))
-#else
   if (!INODE_IS_SPECIAL(inode))

Review comment:
       @acassis, you are right. I misunderstand the logic. The change is wrong, I will abandon it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org