You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/11/01 14:39:08 UTC
Review Request 63463: Added support for credential secret to
test-http-framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63463/
-----------------------------------------------------------
Review request for mesos, Armand Grillet and Alexander Rojas.
Repository: mesos
Description
-------
Adds the ability to authenticate against the master to the test-http-framework.
Diffs
-----
src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e
Diff: https://reviews.apache.org/r/63463/diff/1/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 63463: Added support for credential secret to
test-http-framework.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63463/#review189805
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63463]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Nov. 1, 2017, 2:39 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63463/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2017, 2:39 p.m.)
>
>
> Review request for mesos, Armand Grillet and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds the ability to authenticate against the master to the test-http-framework.
>
>
> Diffs
> -----
>
> src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e
>
>
> Diff: https://reviews.apache.org/r/63463/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 63463: Added support for credential secret to
test-http-framework.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63463/#review189899
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On Nov. 1, 2017, 2:39 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63463/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2017, 2:39 p.m.)
>
>
> Review request for mesos, Armand Grillet and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds the ability to authenticate against the master to the test-http-framework.
>
>
> Diffs
> -----
>
> src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e
>
>
> Diff: https://reviews.apache.org/r/63463/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>